Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable --experimental-local for wrangler pages dev #2268

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

GregBrimble
Copy link
Member

@GregBrimble GregBrimble commented Nov 22, 2022

Fixes #1947

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2022

🦋 Changeset detected

Latest commit: 7e244d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/pages-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GregBrimble GregBrimble changed the title WIP: Enable --experimental-local for wrangler pages dev Enable --experimental-local for wrangler pages dev Nov 24, 2022
@GregBrimble GregBrimble marked this pull request as ready for review November 24, 2022 17:44
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/runs/3601401301/npm-package-wrangler-2268

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/prs/2268/npm-package-wrangler-2268

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/runs/3601401301/npm-package-wrangler-2268 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/runs/3601401301/npm-package-cloudflare-pages-shared-2268

@GregBrimble GregBrimble force-pushed the pages-dev-workerd branch 3 times, most recently from c442af3 to 06efb9a Compare November 28, 2022 12:03
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #2268 (7e244d8) into main (1a1f1dc) will decrease coverage by 0.75%.
The diff coverage is 3.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2268      +/-   ##
==========================================
- Coverage   71.61%   70.86%   -0.76%     
==========================================
  Files         151      152       +1     
  Lines        9585     9705     +120     
  Branches     2494     2533      +39     
==========================================
+ Hits         6864     6877      +13     
- Misses       2721     2828     +107     
Impacted Files Coverage Δ
packages/wrangler/src/miniflare-cli/assets.ts 7.69% <0.00%> (ø)
packages/wrangler/src/pages/dev.tsx 19.02% <ø> (ø)
packages/wrangler/src/dev/local.tsx 22.51% <33.33%> (+0.12%) ⬆️
packages/wrangler/src/git-client.ts 81.25% <0.00%> (+4.16%) ⬆️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

@GregBrimble GregBrimble force-pushed the pages-dev-workerd branch 2 times, most recently from d468386 to d322c0f Compare November 28, 2022 16:36
@GregBrimble GregBrimble changed the base branch from main to concurrent-fixture-tests November 28, 2022 16:37
Base automatically changed from concurrent-fixture-tests to main November 28, 2022 21:26
@GregBrimble GregBrimble force-pushed the pages-dev-workerd branch 7 times, most recently from 585aa33 to b84ac7f Compare November 30, 2022 15:00
@GregBrimble GregBrimble requested a review from mrbbot November 30, 2022 15:01
Copy link
Member

@jrf0110 jrf0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GregBrimble GregBrimble requested a review from a team as a code owner December 1, 2022 15:57
@GregBrimble GregBrimble merged commit 3be1c2c into main Dec 2, 2022
@GregBrimble GregBrimble deleted the pages-dev-workerd branch December 2, 2022 12:34
@github-actions github-actions bot mentioned this pull request Dec 2, 2022
@mrbbot
Copy link
Contributor

mrbbot commented Dec 5, 2022

Once cloudflare/miniflare#453 has landed, this should support WebSocket proxying too. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pages dev --experimental-local
4 participants