-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[quick-edit] Typescript support through JSDoc #3043
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4701718286/npm-package-wrangler-3043 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3043/npm-package-wrangler-3043 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4701718286/npm-package-wrangler-3043 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4701718286/npm-package-cloudflare-pages-shared-3043 Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #3043 +/- ##
==========================================
+ Coverage 73.84% 73.87% +0.02%
==========================================
Files 167 167
Lines 10504 10504
Branches 2807 2807
==========================================
+ Hits 7757 7760 +3
+ Misses 2747 2744 -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! 😃 Added a few comments...
packages/quick-edit/patches/0011-Support-project-wide-typescript-on-web.patch
Outdated
Show resolved
Hide resolved
packages/quick-edit/patches/0011-Support-project-wide-typescript-on-web.patch
Show resolved
Hide resolved
packages/quick-edit/patches/0011-Support-project-wide-typescript-on-web.patch
Show resolved
Hide resolved
f958343
to
fdf203f
Compare
What this PR solves / how to test:
SharedArrayBuffer
, and loads two read-only files into Worker workspaces,jsconfig.json
andworkers-types.d.ts
Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer has performed the following, where applicable: