Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[quick-edit] Typescript support through JSDoc #3043

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Conversation

penalosa
Copy link
Contributor

What this PR solves / how to test:

  • Adds support for Typescript checking, via JSDoc annotations
  • In particular, this patches the VSCode typescript extension to work without SharedArrayBuffer, and loads two read-only files into Worker workspaces, jsconfig.json and workers-types.d.ts

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@penalosa penalosa requested a review from a team as a code owner April 14, 2023 01:02
@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2023

⚠️ No Changeset found

Latest commit: a386115

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4701718286/npm-package-wrangler-3043

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3043/npm-package-wrangler-3043

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4701718286/npm-package-wrangler-3043 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4701718286/npm-package-cloudflare-pages-shared-3043

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #3043 (a386115) into main (b1242d3) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3043      +/-   ##
==========================================
+ Coverage   73.84%   73.87%   +0.02%     
==========================================
  Files         167      167              
  Lines       10504    10504              
  Branches     2807     2807              
==========================================
+ Hits         7757     7760       +3     
+ Misses       2747     2744       -3     

see 2 files with indirect coverage changes

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! 😃 Added a few comments...

@penalosa penalosa requested a review from mrbbot April 14, 2023 13:05
@penalosa penalosa force-pushed the quick-edit/typescript branch from f958343 to fdf203f Compare April 14, 2023 16:04
@penalosa penalosa merged commit 7930471 into main Apr 14, 2023
@penalosa penalosa deleted the quick-edit/typescript branch April 14, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants