refactor: use xxhash-wasm for better compatibility with Windows

.changeset/sixty-fishes-doubt.md

@@ -0,0 +1,9 @@
+---
+"wrangler": patch
+---
+
+refactor: use xxhash-wasm for better compatibility with Windows
+
+The previous xxhash package we were using required a build step, which relied upon tooling that was not always available on Window.
+
+This version is a portable WASM package.

packages/wrangler/package.json

@@ -40,7 +40,7 @@
     "miniflare": "2.2.0",
     "path-to-regexp": "^6.2.0",
     "semiver": "^1.1.0",
-    "xxhash-addon": "^1.4.0"
+    "xxhash-wasm": "^1.0.1"
   },
   "optionalDependencies": {
     "fsevents": "~2.3.2"

packages/wrangler/scripts/bundle.ts

@@ -12,13 +12,7 @@ async function run() {
     platform: "node",
     format: "cjs",
     // minify: true, // TODO: enable this again
-    external: [
-      "fsevents",
-      "esbuild",
-      "miniflare",
-      "@miniflare/core",
-      "xxhash-addon",
-    ], // todo - bundle miniflare too
+    external: ["fsevents", "esbuild", "miniflare", "@miniflare/core"], // todo - bundle miniflare too
     sourcemap: true,
     inject: [path.join(__dirname, "../import_meta_url.js")],
     define: {

packages/wrangler/src/sites.tsx

@@ -1,14 +1,15 @@
 import { readdir, readFile, stat } from "node:fs/promises";
 import * as path from "node:path";
 import ignore from "ignore";
-import { XXHash64 } from "xxhash-addon";
+import xxhash from "xxhash-wasm";
 import {
   createNamespace,
   listNamespaceKeys,
   listNamespaces,
   putBulkKeyValue,
 } from "./kv";
 import type { Config } from "./config";
+import type { XXHashAPI } from "xxhash-wasm";
 
 /** Paths to always ignore. */
 const ALWAYS_IGNORE = ["node_modules"];
@@ -46,11 +47,8 @@ async function* getFilesInFolder(dirPath: string): AsyncIterable<string> {
  * the most important thing here is to detect changes of a single file to invalidate the cache and
  * it's impossible to serve two different files with the same name
  */
-function hashFileContent(content: string): string {
-  const hasher = new XXHash64();
-  hasher.update(Buffer.from(content));
-  const hash = hasher.digest();
-  return hash.toString("hex").substring(0, 10);
+function hashFileContent(hasher: XXHashAPI, content: string): string {
+  return hasher.h64ToString(content).substring(0, 10);
 }
 
 /**
@@ -59,11 +57,15 @@ function hashFileContent(content: string): string {
  * The key will change if the file path or content of the asset changes.
  * The algorithm used here matches that of Wrangler 1.
  */
-function hashAsset(filePath: string, content: string): string {
+function hashAsset(
+  hasher: XXHashAPI,
+  filePath: string,
+  content: string
+): string {
   const extName = path.extname(filePath) || "";
   const baseName = path.basename(filePath, extName);
   const directory = path.dirname(filePath);
-  const hash = hashFileContent(content);
+  const hash = hashFileContent(hasher, content);
   return urlSafe(path.join(directory, `${baseName}.${hash}${extName}`));
 }
 
@@ -136,6 +138,8 @@ export async function syncAssets(
 
   const include = createPatternMatcher(siteAssets.includePatterns, false);
   const exclude = createPatternMatcher(siteAssets.excludePatterns, true);
+  const hasher = await xxhash();
+
   // TODO: this can be more efficient by parallelising
   for await (const file of getFilesInFolder(siteAssets.baseDirectory)) {
     if (!include(file)) {
@@ -149,7 +153,7 @@ export async function syncAssets(
     console.log(`reading ${file}...`);
     const content = await readFile(file, "base64");
 
-    const assetKey = hashAsset(file, content);
+    const assetKey = await hashAsset(hasher, file, content);
     validateAssetKey(assetKey);
 
     // now put each of the files into kv