Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft Worker for Bulk Secrets #4028

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

JacobMGEvans
Copy link
Contributor

When Secrets are uploaded if there is no Worker in place already it will fail, this allows for the same draft worker logic to retry adding the secrets

Fixes # cloudflare/wrangler-action#162

@JacobMGEvans JacobMGEvans requested a review from a team as a code owner September 25, 2023 17:56
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

🦋 Changeset detected

Latest commit: 70c5af4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6313758002/npm-package-wrangler-4028

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6313758002/npm-package-wrangler-4028

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6313758002/npm-package-wrangler-4028 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6313758002/npm-package-cloudflare-pages-shared-4028

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.9.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230922.0 3.20230922.0
workerd 1.20230922.0 1.20230922.0
workerd --version 1.20230922.0 2023-09-22

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@JacobMGEvans JacobMGEvans force-pushed the jacobmgevans/bulk-secret-draft-worker branch from 379e700 to 105bbfb Compare September 25, 2023 18:39
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #4028 (5f9b802) into main (3cd7286) will increase coverage by 0.12%.
The diff coverage is 60.00%.

❗ Current head 5f9b802 differs from pull request most recent head 70c5af4. Consider uploading reports for the commit 70c5af4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4028      +/-   ##
==========================================
+ Coverage   74.94%   75.07%   +0.12%     
==========================================
  Files         207      200       -7     
  Lines       11826    11671     -155     
  Branches     3079     3060      -19     
==========================================
- Hits         8863     8762     -101     
+ Misses       2963     2909      -54     
Files Coverage Δ
packages/wrangler/src/secret/index.ts 88.51% <60.00%> (+1.18%) ⬆️

... and 18 files with indirect coverage changes

@JacobMGEvans JacobMGEvans force-pushed the jacobmgevans/bulk-secret-draft-worker branch 3 times, most recently from 8b15080 to 5f9b802 Compare September 25, 2023 18:59
When Secrets are uploaded if there is no Worker in place already it will fail, this allows for the same draft worker logic to retry adding the secrets
@JacobMGEvans JacobMGEvans force-pushed the jacobmgevans/bulk-secret-draft-worker branch from 5f9b802 to 70c5af4 Compare September 26, 2023 13:58
@JacobMGEvans JacobMGEvans merged commit d538973 into main Sep 26, 2023
14 checks passed
@JacobMGEvans JacobMGEvans deleted the jacobmgevans/bulk-secret-draft-worker branch September 26, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants