-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove confusing --local
messaging from wrangler pages dev
#4687
Conversation
🦋 Changeset detectedLatest commit: b82875d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-wrangler-4687 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7389823023/npm-package-wrangler-4687 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-wrangler-4687 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-miniflare-4687 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-cloudflare-pages-shared-4687 npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-create-cloudflare-4687 --no-auto-update Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 😍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4687 +/- ##
==========================================
+ Coverage 75.58% 75.61% +0.02%
==========================================
Files 243 243
Lines 13084 13084
Branches 3368 3368
==========================================
+ Hits 9890 9893 +3
+ Misses 3194 3191 -3
|
24c41df
to
b82875d
Compare
--local
messaging from wrangler pages dev
--local
messaging from wrangler pages dev
Already discussed in person, but flagging here for posterity: The warning now doesn't appear if you don't set The warning ALSO doesn't appear if you DO set |
Fixes #4210.
What this PR solves / how to test:
Running
wrangler pages dev
would previously log a warning saying--local is no longer required
even though--local
was never set. This change removes this warning. To test this, runwrangler pages dev
and make sure--local is no longer required
doesn't appear.Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.