Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove confusing --local messaging from wrangler pages dev #4687

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Jan 2, 2024

Fixes #4210.

What this PR solves / how to test:

Running wrangler pages dev would previously log a warning saying --local is no longer required even though --local was never set. This change removes this warning. To test this, run wrangler pages dev and make sure --local is no longer required doesn't appear.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: removing old messaging

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@mrbbot mrbbot requested a review from a team as a code owner January 2, 2024 18:30
Copy link

changeset-bot bot commented Jan 2, 2024

🦋 Changeset detected

Latest commit: b82875d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 2, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-wrangler-4687

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7389823023/npm-package-wrangler-4687

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-wrangler-4687 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-miniflare-4687
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-cloudflare-pages-shared-4687
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-create-cloudflare-4687 --no-auto-update

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.22.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.4
workerd 1.20231218.0 1.20231218.0
workerd --version 1.20231218.0 2023-12-18

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 😍

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c410ea1) 75.58% compared to head (b82875d) 75.61%.
Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4687      +/-   ##
==========================================
+ Coverage   75.58%   75.61%   +0.02%     
==========================================
  Files         243      243              
  Lines       13084    13084              
  Branches     3368     3368              
==========================================
+ Hits         9890     9893       +3     
+ Misses       3194     3191       -3     
Files Coverage Δ
packages/wrangler/src/api/dev.ts 82.85% <ø> (ø)

... and 5 files with indirect coverage changes

@mrbbot mrbbot force-pushed the bcoll/pages-dev-dash-dash-local-cleanup branch from 24c41df to b82875d Compare January 2, 2024 19:39
@mrbbot mrbbot changed the title fix: remote confusing --local messaging from wrangler pages dev fix: remove confusing --local messaging from wrangler pages dev Jan 3, 2024
@RamIdeas
Copy link
Contributor

RamIdeas commented Jan 9, 2024

Already discussed in person, but flagging here for posterity:

The warning now doesn't appear if you don't set --local

The warning ALSO doesn't appear if you DO set --local (confirmed this is okay since the arg isn't valid for pages dev but it doesn't trigger the help text because... reasons??)

@mrbbot mrbbot merged commit 0a488f6 into main Jan 10, 2024
17 checks passed
@mrbbot mrbbot deleted the bcoll/pages-dev-dash-dash-local-cleanup branch January 10, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants