update solid c3 configs to work with new solid-start beta-2

[dario-piotrowicz]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 51f9937

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7396313388/npm-package-wrangler-4689

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7396313388/npm-package-wrangler-4689

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7396313388/npm-package-wrangler-4689 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7396313388/npm-package-miniflare-4689

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7396313388/npm-package-cloudflare-pages-shared-4689

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7396313388/npm-package-create-cloudflare-4689 --no-auto-update

Note that these links will no longer work once the GitHub Actions artifact expires.

---

wrangler@3.22.2 includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20231218.0
workerd	1.20231218.0	1.20231218.0
workerd --version	1.20231218.0	2023-12-18

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (259b5a6) 75.58% compared to head (51f9937) 75.64%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4689      +/-   ##
==========================================
+ Coverage   75.58%   75.64%   +0.05%     
==========================================
  Files         243      243              
  Lines       13084    13084              
  Branches     3368     3368              
==========================================
+ Hits         9890     9897       +7     
+ Misses       3194     3187       -7     

see 6 files with indirect coverage changes

[dario-piotrowicz]

never mind, it actually does work, the config needs to look like this:

import { defineConfig } from "@solidjs/start/config";

export default defineConfig({
  start: {
    server: {
      preset: "cloudflare-pages"
    }
  }
});

(PS: I am pretty sure this didn't work when I opened the PR, maybe they've fixed it upstream 🤷 )

[dario-piotrowicz]

I'm closing this PR as the only change I made is not actually relevant anymore, and also I think that there is a build issue that needs to be solved upstream before we can do anything on our side: solidjs/solid-start#1217