-
Notifications
You must be signed in to change notification settings - Fork 952
Gradual Rollouts versions upload
(experimental) command
#4744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7629237740/npm-package-wrangler-4744 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4744/npm-package-wrangler-4744 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7629237740/npm-package-wrangler-4744 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7629237740/npm-package-create-cloudflare-4744 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7629237740/npm-package-miniflare-4744 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7629237740/npm-package-cloudflare-pages-shared-4744 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4744 +/- ##
==========================================
- Coverage 71.47% 70.59% -0.88%
==========================================
Files 288 290 +2
Lines 14831 15075 +244
Branches 3729 3818 +89
==========================================
+ Hits 10600 10642 +42
- Misses 4231 4433 +202
|
the only feedback i have here is from the DX side. once you upload the new version, it would be great if you could capture it from wrangler without needing to make another API call to the version (similar to what already happens with
|
696f143
to
1402c69
Compare
b89281e
to
2a768c8
Compare
remove first_party_worker logs since not needed for versions upload
to enable `versions upload` command
747a909
to
79b2880
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Aside from some concerns about UserError
s all these comments are non-blocking.
versions upload
commandversions upload
(experimental) command
What this PR solves / how to test:
This PR implements the new Gradual Rollouts
versions upload
command for internal-use only. Therefore, it is hidden from the help output.The command is gated behind the new
--experimental-gradual-rollouts
flag.The command is essentially the same as
deploy
(except using a different endpoint and without applying any triggers) and, for now, has been duplicated so as not to touch the deploy command implementation at all and, while we agree on the differences, the diff should be more readable this way.The PR is marked as draft and will be refactored to abstracted functions of shared implementation at a granular level before being marked as ready for review. This should allow internal use of the prerelease builds before going through that effort.To avoid teams relying a prerelease builds, we have decided to merge this as-is, and will follow up with tests and refactoring to share code with deploy in a future PR anticipated by week beginning Feb 5th.Please find the prerelease build instructions in a bot comment below. Specifically for this command you can run:
Important
The URL in the command above will be updated as commits/changes are validated. Please refer back here for the latest stable prerelease build.
Author has addressed the following:
–experimental-gradual-rollouts
. Further, as noted above, "To avoid teams relying a prerelease builds, we have decided to merge this as-is, and will follow up with tests and refactoring to share code with deploy in a future PR anticipated by week beginning Feb 5th."Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.