[wrangler] fix: stop rebuild attempts when sources are missing (#3886) #4877

magnusdahlstrand · 2024-01-30T20:08:40Z

What this PR solves / how to test:

As I've been working on a site using sveltekit and its adapter-cloudflare alongside workers-sdk I've been seeing lots of errors in the console (as those in the issue linked above) referring to missing files. This is due to rebuilds of the worker file being triggered on all file changes, including "unlink" events, which with lots of build pipelines happen at the beginning of a build.

In effect this means that we watch files for change, notice that a file has been deleted, and then try to rebuild, although we can guarantee that at this point the build will file, since the watched file no longer exists, and instead we should just hold on a few seconds until the build finishes and the "add" or "change" event is emitted.

Author has addressed the following:

This PR updates the behaviour of the dev.ts' worker script building to ignore "unlink" events on the worker file as well as the route files, so rebuilds are only triggered on events which add or modify said files. This means that no more ENOENT errors for missing _worker.js or _routes.json when watching for changes.

Tests
- Included
- Not necessary because: Removes intermittent errors during development watch experience which doesn't seem to be tested for.
Changeset (Changeset guidelines)
- Included
- Not necessary because:
Associated docs
- Issue(s)/PR(s): 🐛 BUG: wrangler pages dev hot reloading error on Next.js local development #3886
- Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

…flare#3886)

changeset-bot · 2024-01-30T20:08:44Z

🦋 Changeset detected

Latest commit: 52c3111

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-01-31T10:05:27Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7732497279/npm-package-wrangler-4877

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4877/npm-package-wrangler-4877

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7732497279/npm-package-wrangler-4877 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7732497279/npm-package-create-cloudflare-4877 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7732497279/npm-package-miniflare-4877

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7732497279/npm-package-cloudflare-pages-shared-4877

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.26.0 includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20240129.0
`workerd`	1.20240129.0	1.20240129.0
`workerd --version`	1.20240129.0	2024-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

codecov · 2024-01-31T10:09:19Z

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2f57a35) 70.65% compared to head (52c3111) 70.69%.
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4877      +/-   ##
==========================================
+ Coverage   70.65%   70.69%   +0.04%     
==========================================
  Files         292      292              
  Lines       15178    15182       +4     
  Branches     3859     3862       +3     
==========================================
+ Hits        10724    10733       +9     
+ Misses       4454     4449       -5

Files	Coverage Δ
packages/wrangler/src/pages/dev.ts	`15.98% <0.00%> (-0.23%)`	⬇️

... and 10 files with indirect coverage changes

…cloudflare#3886)

petebacondarwin · 2024-01-31T10:32:53Z

Thanks for this PR @magnusdahlstrand - I pushed a commit with a test for this change of functionality.
Could you add one for the _routes.json too please?

petebacondarwin

LGTM once we add the extra test and perhaps consider adding to the changeset message as proposed.

.changeset/hip-files-count.md

…cloudflare#3886)

Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>

cloudflare#3886)

magnusdahlstrand · 2024-01-31T19:48:23Z

I've provided a test for it, starting off from what you created for the worker.js @petebacondarwin.

I had to createa routes.json file in the example project for there to be one to rename.

It seems the code path that builds when the route changes is different from when the worker changes and doesn't use the buildRawWorker method, which means that there's no Compiled Worker successfully success message after builds complete which we can listen to.

I'm not deep enough in the flow of pages/dev.ts to understand why they're using different codepaths, and since the test setup only builds and doesn't run a server, listening to the Reloading local server... message doesn't work either, so I've just set the test to complete if there's no further output, which isn't ideal, but I'm unsure what else to check for.

Better I guess would be if the build which happens from _routes.json changes would have its own success message, but playing around with adding that means that we get two success messages when pages dev first runs or whenever a full build happens, so I left the routes build with no output. If there was a verbose mode for the logger we could output route build successes there perhaps, but that feels like a separate PR.

Let me know if you have any feedback!

petebacondarwin

Nice!

cloudflare#3886)

jaaneh · 2024-02-05T04:23:56Z

Trying the prerelease here to hopefully fix crashes when saving a file, but the same issue is still persistent for me. Running these in separate terminals will result in ENOENT scandir fr the _worker.js file for both the 3.26.0 and prerelease version.

"pages:watch": "npx @cloudflare/next-on-pages --watch",
"pages:dev": "wrangler pages dev .vercel/output/static --compatibility-date=2024-01-29 --compatibility-flag=nodejs_compat",

Currently I'm forced to run lsof -i :8788 and kill -9 <pid> every time I save a file, just to restart pages:dev to see changes. Having this issue fixed will improve DX a lot! Thanks

magnusdahlstrand · 2024-02-05T15:21:09Z

@jaaneh Do you have a repo with your next/vercel setup that I can run to test it out on my side? I'm using sveltekit but I don't see why it wouldn't work with next also.

jaaneh · 2024-02-05T15:32:29Z

@jaaneh Do you have a repo with your next/vercel setup that I can run to test it out on my side? I'm using sveltekit but I don't see why it wouldn't work with next also.

@magnusdahlstrand
Unfortunately my project is not public, but my setup is based off of and identical to this template. Just quickly tried it with a fresh clone from there as well and getting the same thing.

Steps taken

Clone template
yarn install
yarn add -D https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7732497279/npm-package-wrangler-4877
yarn pages:watch and yarn pages:dev in separate terminals
Open any file such as /app/page.tsx and hit save.

dario-piotrowicz · 2024-02-05T22:37:12Z

@jaaneh I could not reproduce the issue in the way you described, in order to get the issue I had to downgrade the wrangler package...

Could you double check and make sure that you're not getting an older version of wrangler or something like that 😕

(PS: I tested this with npm as yarn wasn't really working for me, I am not sure if that can make the difference 😕)

By the way, are you familiar with the new next-on-pages next-dev submodule? That should give you a much improved DX and avoid this issue althogether

jaaneh · 2024-02-06T04:58:33Z

@dario-piotrowicz thanks so much for checking!

Looking at it closer, and trying with npm, yarn and pnpm, they all seem to install wrangler@0.0.0-2338c639 which could be the reason the server still crashes on reload for me. Not 100% sure how to force it to install the prerelease. I guess I'll wait for #4891 to be merged.

My project has next-dev submodule set up similarly to the template I linked previously. However, running Next using their next dev command leads to other issues with querying D1 in my app and forces me to use pages:watch and pages:dev in order to serve my app without errors. Hence why the hot reloading issue is quite annoying.

Edit
Actually, I figured out the above error. My setupDevBindings type was incorrect.

DB: {
-   type: "D1Database",
+   type: "d1",
    databaseId: "db-uuid"
}

Now running Next.js app with next dev works fine!

petebacondarwin · 2024-02-06T07:56:24Z

@dario-piotrowicz I wonder if we could validate and make visible such errors in the config?

dario-piotrowicz · 2024-02-06T09:19:12Z

@petebacondarwin there are already valid typescript types there, so developers should get autocompletion from their IDE, unfortunately since the config file is a js one they don't get errors when not following the types 😓 (unless they manually add a // @ts-check at the top)

We could introduce some runtime validation so that we can show warnings/errors in the terminal, but since we're deprecating that API (cloudflare/next-on-pages#648) I don't know if that's worth it (setupDevPlatform already has baked-in validation when reading the bindings from the toml file)

jaaneh · 2024-02-06T09:38:06Z

Just to be clear, this was totally a *me* issue. There is autocompletion there, but seeing as I copied this from a template it seems like they had theirs set up incorrectly and in turn led me to also have it wrong. The error I got wasn't related at all so finding the cause wasn't the easiest.

Super sorry for hijacking this PR. Thanks so much for the help!

* ci: only deploy Workers when pushing to special branches (#4848) Previously every push to `main` that contained changes to a Worker package would cause that Worker to be deploy "to production". This meant that we had to be very careful about merging PRs that touch these Workers files. Now production deployment is only run for a Worker on a push to its special deployment branch (e.g. `deploy-worker/playground-preview-worker`). This allows us to land PRs to `main` and then collect up changes to release in a single go by updating the special deployment branch in a controlled way. Moreover it is also easy to see what changes will be released by looking at the difference between `main` and the deployment branch for the Worker package directory. The three workers in this repo now follow this pattern: - edge-preview-authenticated-proxy - format-errors - playground-preview-worker In addition, the Playground Preview Worker has end-to-end tests that are run on every push to the `main` branch, and also any PRs that have the "playground-worker" label. For these tests the Worker is deployed to the testing environment before running the tests against this deployment. * C3: bump `create-next-app` and handle new `next.config.mjs` defaults (#4863) * bump create-next-app from 14.0.4 to 14.1.0 * C3: handle new next.config.mjs default files * [wrangler] Support ai bindings in getBindingsProxy (#4869) * Retain AI service binding from miniflare options * Update changeset * chore: bump `workerd` to `1.20240129.0` (#4874) * [C3] Bump create-vue from 3.9.1 to 3.9.2 in /packages/create-cloudflare/src/frameworks (#4870) * [C3] Bump create-vue in /packages/create-cloudflare/src/frameworks Bumps [create-vue](https://github.com/vuejs/create-vue) from 3.9.1 to 3.9.2. - [Release notes](https://github.com/vuejs/create-vue/releases) - [Commits](vuejs/create-vue@v3.9.1...v3.9.2) --- updated-dependencies: - dependency-name: create-vue dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * [C3] Update frameworks cli dependencies --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com> * Exclude standardPricingWarning from dryrun (#4880) * Exclude standardPricingWarning from dryrun That way we do not need authentication for dryrun, again. * fixup! Exclude standardPricingWarning from dryrun * fixup! Exclude standardPricingWarning from dryrun --------- Co-authored-by: petero-dk <2478689+petero-dk@users.noreply.github.com> * Implements Python support in miniflare. (#4873) * Fix changesets (#4885) * fix dario-piotrowicz's changesets * fix existing C3 changesets and amend the changeset text in the creation logic * Version Packages (#4854) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [C3] Bump create-qwik from 1.4.2 to 1.4.3 in /packages/create-cloudflare/src/frameworks (#4881) * [C3] Bump create-qwik in /packages/create-cloudflare/src/frameworks Bumps [create-qwik](https://github.com/BuilderIO/qwik/tree/HEAD/packages/create-qwik) from 1.4.2 to 1.4.3. - [Release notes](https://github.com/BuilderIO/qwik/releases) - [Commits](https://github.com/BuilderIO/qwik/commits/v1.4.3/packages/create-qwik) --- updated-dependencies: - dependency-name: create-qwik dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * [C3] Update frameworks cli dependencies --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com> * [wrangler] fix: listen on loopback for wrangler dev port check and login (#4830) The `wrangler dev` port availability check triggers a firewall prompt on macOS while it briefly opens and closes listeners. The OAuth callback server from `wrangler login` has the same issue. Fix both cases by listening on the loopback address only by default. Fixed some new test failures by using locally available IP addresses: wrangler:test: ● wrangler dev › ip › should use to `ip` from `wrangler.toml`, if available wrangler:test: listen EADDRNOTAVAIL: address not available 1.2.3.4:8787 wrangler:test: wrangler:test: ● wrangler dev › ip › should use --ip command line arg, if provided wrangler:test: listen EADDRNOTAVAIL: address not available 5.6.7.8:8787 Relates to #4430 * remove outdated and no longer valid miniflare development section from CONTRIBUTING.md (#4893) * [C3] Bump @angular/create from 17.1.1 to 17.1.2 in /packages/create-cloudflare/src/frameworks (#4892) * [C3] Bump @angular/create in /packages/create-cloudflare/src/frameworks Bumps [@angular/create](https://github.com/angular/angular-cli) from 17.1.1 to 17.1.2. - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@17.1.1...17.1.2) --- updated-dependencies: - dependency-name: "@angular/create" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * [C3] Update frameworks cli dependencies --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com> * [Stream] WebRTC Template Improvements (#4157) * Add port numbers to fix stackblitz automatic startup * Pull the variables up and show clear instructions * fixup! Pull the variables up and show clear instructions --------- Co-authored-by: Peter Bacon Darwin <pbacondarwin@cloudflare.com> * fix: return 4xx error from playground preview worker on invalid tokens (#4904) Previously, we were passing user-controllable token inputs (`X-CF-Token` header, `user` search param, `token` cookie) directly to the `DurableObjectNamespace#idFromString()` function. This validated the token to be a valid Durable Object ID, but threw a reportable `TypeError`, generating a 500 response and increasing the errored request count. This is a user error, so shouldn't be reported. This change wraps calls to `idFromString()` inside `try`/`catch`es, and re-throws non-reportable user errors that generate 4xx responses. We could just validate that the tokens were 64 hex digits before calling `idFromString()`, but this approach ensures the IDs are for the `UserSession` object by validating the signature encoded in the ID too. * chore: rename deprecated Vitest `TestContext.meta` properties to `TestContext.task` (#4897) This is a precursor to updating to latest Vitest. * [wrangler] fix: stop rebuild attempts when sources are missing (#3886) (#4877) * [wrangler] fix: stop rebuild attempts when sources are missing (#3886) * fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886) * fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886) * fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886) * Update .changeset/hip-files-count.md Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com> * !fixup: [wrangler] fix: stop rebuild attempts when sources are missing (#3886) * !fixup: [wrangler] fix: stop rebuild attempts when sources are missing (#3886) --------- Co-authored-by: Peter Bacon Darwin <pbacondarwin@cloudflare.com> Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com> * [C3] Bump create-remix from 2.5.1 to 2.6.0 in /packages/create-cloudflare/src/frameworks (#4903) * [C3] Bump create-remix in /packages/create-cloudflare/src/frameworks Bumps [create-remix](https://github.com/remix-run/remix/tree/HEAD/packages/create-remix) from 2.5.1 to 2.6.0. - [Release notes](https://github.com/remix-run/remix/releases) - [Changelog](https://github.com/remix-run/remix/blob/main/packages/create-remix/CHANGELOG.md) - [Commits](https://github.com/remix-run/remix/commits/create-remix@2.6.0/packages/create-remix) --- updated-dependencies: - dependency-name: create-remix dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * [C3] Update frameworks cli dependencies --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com> * fix: ensure that the Pages dev proxy server does not change the Host header (#4888) * fix: ensure that the Pages dev proxy server does not change the Host header Previously, when configuring `wrangler pages dev` to use a proxy to a 3rd party dev server, the proxy would replace the Host header, resulting in problems at the dev server if it was checking for cross-site scripting attacks. Now the proxy server passes through the Host header unaltered making it invisible to the 3rd party dev server. Fixes #4799 * fixup! fix: ensure that the Pages dev proxy server does not change the Host header * fixup! fix: ensure that the Pages dev proxy server does not change the Host header * fixup! fix: ensure that the Pages dev proxy server does not change the Host header * fix: fallback to returning stack trace if `format-errors` broken (#4908) * expose cf object from Miniflare instances (#4905) * expose cf object from Miniflare instances --------- Co-authored-by: MrBBot <bcoll@cloudflare.com> * Add a `ctx` field to the `getBindingsProxy` result (#4922) * split get-bindings-proxy fixture tests in multiple files * add ctx to getBindingsProxy * add ctx tests to get-bindings-proxy fixture --------- Co-authored-by: MrBBot <bcoll@cloudflare.com> * fix(d1): intercept and stringify errors thrown in --json mode (#4872) * fix(d1): intercept and stringify errors thrown in --json mode * fix: add light parsing on d1 execute error message * add test * wip * implement JsonFriendlyFatalError * address PR feedback * fix: don't report invalid `format-errors` input (#4911) * [D1] Add user friendly D1 validation error messages for `dev --remote` and `deploy` (#4914) * chore: refactor user friendly errors and add 10063 code handling * chore: add user friendly error message to deployments * chore: lint * chore: cleanup directory * chore: fix remote error handling * chore: add patch change set * chore: move ABORT_ERR logic out of the user friendly error handler * chore: fix syntax * Update .changeset/fair-shoes-melt.md Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com> --------- Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com> * [D1] teach wrangler how to fetch insights about D1's queries (#4909) * [D1] teach wrangler how to fetch insights about D1's queries * add options for sorting and number of results * add a means of filtering the datetime geq/leq * add more options, fix tests * add wrangler banner, add warning text * add changeset * rename last to timePeriod * use string format over numbers as >1mo's data could be possible * Update red-icons-flow.md * make it possible to order by count * Update red-icons-flow.md * PR feedback * Update .changeset/red-icons-flow.md Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com> * address PR feedback --------- Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com> * [wrangler] test: fix E2E tests (#4907) * ci: ensure E2E tests failures not reported as successes #4458 accidentally left `continue-on-error: true` in the workflow. This meant that E2E test failures weren't reported as check failures. * test: remove redundant `deploy.test.ts` E2E test This test was a strict subset of `deployments.test.ts`, and wasn't providing any additional value. * test: remove standard pricing warning from E2E test output This warning may not be shown if an account has opted-in to standard pricing. This change normalises output to remove it, meaning tests can be run on any account, regardless of opt-in state. * test: update format of writing logs message in E2E tests * test: use `fallback` instead of `default` in E2E tests #4571 updated the message logged in non-interactive contexts for default values to use the word `fallback` instead of `default`. * fix: ensure `--log-level` argument applied immediately Some messages were being logged before the `--log-level` argument was applied. In particular, this meant the "writing logs to" message at `debug` level, was not output when using `--log-level=debug`. * test: improve reliability of `dev.test.ts` E2E test This change makes a few improvements to `dev.test.ts`: - Shorter timeouts for `fetch()` retries - Replaces `get-port` with native port `0` implementation - Waits for stdout handlers to be registered before starting `wrangler dev` - Ignores errors if we failed to find a proccess to kill (assumes the process was already killed) * fix: throw `UserError`s for R2 object/bucket not-found errors These errors should not be reported to Sentry. * global install * Ensure internal workers listen on ipv4 only * shorter timeouts --------- Co-authored-by: Samuel Macleod <smacleod@cloudflare.com> * Python support (#4901) * Implements wrangler deploy/dev support for Python. * Migrate to `--no-bundle` approach * Basic support for `requirements.txt` * address review comments * Strip package versions * Support deploying * Address comments * Fix tests --------- Co-authored-by: Dominik Picheta <dominik@cloudflare.com> * Version Packages (#4891) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [C3] Add `getBindingsProxy` support to qwik template (#4927) * Split package.json update into multiple phases * Add getBindingsProxy to qwik template * Add support for testing dev scripts in c3 e2e tests * Refactor framework e2e verification helpers * Add support for verifying build script in framework e2es * Refactor e2e helpers * Refactor workers e2e tests to re-align with frameworks tests * Refactor RunnerConfig in e2e tests * Fixing cli e2e tests * changeset * remove leftover test value * Fix issue with npm tests & fix e2e logging * Addressing PR feedback * [playground-preview-worker] fix: don't report invalid upload input (#4937) * fix: don't report invalid `edge-preview-authenticated-proxy` URLs (#4939) * [D1] print wrangler banner at the start of every D1 command (#4938) * fix: make the entrypoint optional for the `types` command (#4931) --------- Co-authored-by: MrBBot <bcoll@cloudflare.com> * add a `cf` field to the `getBindingsProxy` result (#4926) --------- Co-authored-by: James Culveyhouse <jculveyhouse@cloudflare.com> * Improve DX with `node:*` modules (#4499) * Turn node build failures into warnings * Allow files to suppress warnings for specific modules * Remove comment-based allow-listing * Add changeset * Update .changeset/chatty-balloons-impress.md Co-authored-by: James M Snell <jasnell@gmail.com> * Pass through `defineNavigatorUserAgent` * Add tests * lockfile * Linting * fix tests --------- Co-authored-by: James M Snell <jasnell@gmail.com> * improve(r2): Update Sippy endpoint request payloads to match new schema (#4928) * fix(r2): update Sippy API request payloads * improve(r2): rename sippy flags for clarity * improve(r2): stricter existence in Sippy * [C3] Bump create-qwik from 1.4.3 to 1.4.4 in /packages/create-cloudflare/src/frameworks (#4935) * [C3] Bump create-qwik in /packages/create-cloudflare/src/frameworks Bumps [create-qwik](https://github.com/BuilderIO/qwik/tree/HEAD/packages/create-qwik) from 1.4.3 to 1.4.4. - [Release notes](https://github.com/BuilderIO/qwik/releases) - [Commits](https://github.com/BuilderIO/qwik/commits/v1.4.4/packages/create-qwik) --- updated-dependencies: - dependency-name: create-qwik dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * [C3] Update frameworks cli dependencies --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com> * fix: allow `port` option to be specified with `unstable_dev()` (#4953) * Extend error handling of proxy request errors in ProxyWorker (#4867) * ignore stale proxy errors * attempt to recover from ProxyWorker fetch errors by requeuing the request (only if it is GET or HEAD) * add test * add changeset * refactor to flatten nested if-else blocks * requeue request for retry at front of queue * sort batch of requests in queue by order of arrival * Revert "sort batch of requests in queue by order of arrival" This reverts commit 3329f19. * Revert "requeue request for retry at front of queue" This reverts commit f0377b7. * prioritise requests being retried over requests being proxied for the first time * better comments * update changeset to match recommeded format * Update five-cooks-share.md (#4956) * Version Packages (#4934) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com> Co-authored-by: Dario Piotrowicz <dario@cloudflare.com> Co-authored-by: James Culveyhouse <jculveyhouse@cloudflare.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com> Co-authored-by: petero-dk <2478689+petero-dk@users.noreply.github.com> Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com> Co-authored-by: workers-devprod@cloudflare.com <116369605+workers-devprod@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Wu <peter@lekensteyn.nl> Co-authored-by: Taylor Smith <tsmith@tsmith.com> Co-authored-by: Peter Bacon Darwin <pbacondarwin@cloudflare.com> Co-authored-by: Magnus Dahlstrand <magnusdahlstrand@users.noreply.github.com> Co-authored-by: Max Rozen <3822106+rozenmd@users.noreply.github.com> Co-authored-by: Nora Söderlund <norasoderlund@icloud.com> Co-authored-by: Samuel Macleod <smacleod@cloudflare.com> Co-authored-by: Dominik Picheta <dominik@cloudflare.com> Co-authored-by: James M Snell <jasnell@gmail.com> Co-authored-by: Siddhant <siddhant@cloudflare.com> Co-authored-by: Rahul Sethi <5822355+RamIdeas@users.noreply.github.com>

[wrangler] fix: stop rebuild attempts when sources are missing (cloud…

a8da1b8

…flare#3886)

magnusdahlstrand requested review from a team as code owners January 30, 2024 20:08

petebacondarwin self-requested a review January 31, 2024 10:31

fixup! [wrangler] fix: stop rebuild attempts when sources are missing (…

3785c25

…cloudflare#3886)

petebacondarwin requested changes Jan 31, 2024

View reviewed changes

.changeset/hip-files-count.md Outdated Show resolved Hide resolved

petebacondarwin added 2 commits January 31, 2024 11:44

fixup! [wrangler] fix: stop rebuild attempts when sources are missing (…

9723e08

…cloudflare#3886)

fixup! [wrangler] fix: stop rebuild attempts when sources are missing (…

cf9a391

…cloudflare#3886)

petebacondarwin added the awaiting reporter response Needs clarification or followup from OP label Jan 31, 2024

magnusdahlstrand and others added 2 commits January 31, 2024 16:45

Update .changeset/hip-files-count.md

c0d2ce2

Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>

!fixup: [wrangler] fix: stop rebuild attempts when sources are missing (

b339e06

cloudflare#3886)

petebacondarwin approved these changes Jan 31, 2024

View reviewed changes

petebacondarwin removed the awaiting reporter response Needs clarification or followup from OP label Jan 31, 2024

!fixup: [wrangler] fix: stop rebuild attempts when sources are missing (

52c3111

cloudflare#3886)

petebacondarwin merged commit 3e7cd6e into cloudflare:main Feb 2, 2024
17 checks passed

workers-devprod mentioned this pull request Feb 2, 2024

Version Packages #4891

Merged

CarmenPopoviciu mentioned this pull request Jul 2, 2024

fix(wrangler): Fix pages dev watch mode [_worker.js] #6150

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wrangler] fix: stop rebuild attempts when sources are missing (#3886) #4877

[wrangler] fix: stop rebuild attempts when sources are missing (#3886) #4877

magnusdahlstrand commented Jan 30, 2024

changeset-bot bot commented Jan 30, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

codecov bot commented Jan 31, 2024 •

edited

Loading

petebacondarwin commented Jan 31, 2024

petebacondarwin left a comment

magnusdahlstrand commented Jan 31, 2024 •

edited

Loading

petebacondarwin left a comment

jaaneh commented Feb 5, 2024

magnusdahlstrand commented Feb 5, 2024

jaaneh commented Feb 5, 2024 •

edited

Loading

dario-piotrowicz commented Feb 5, 2024

jaaneh commented Feb 6, 2024 •

edited

Loading

petebacondarwin commented Feb 6, 2024

dario-piotrowicz commented Feb 6, 2024

jaaneh commented Feb 6, 2024 •

edited

Loading

[wrangler] fix: stop rebuild attempts when sources are missing (#3886) #4877

[wrangler] fix: stop rebuild attempts when sources are missing (#3886) #4877

Conversation

magnusdahlstrand commented Jan 30, 2024

changeset-bot bot commented Jan 30, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Jan 31, 2024 • edited Loading

codecov bot commented Jan 31, 2024 • edited Loading

Codecov Report

petebacondarwin commented Jan 31, 2024

petebacondarwin left a comment

Choose a reason for hiding this comment

magnusdahlstrand commented Jan 31, 2024 • edited Loading

petebacondarwin left a comment

Choose a reason for hiding this comment

jaaneh commented Feb 5, 2024

magnusdahlstrand commented Feb 5, 2024

jaaneh commented Feb 5, 2024 • edited Loading

dario-piotrowicz commented Feb 5, 2024

jaaneh commented Feb 6, 2024 • edited Loading

petebacondarwin commented Feb 6, 2024

dario-piotrowicz commented Feb 6, 2024

jaaneh commented Feb 6, 2024 • edited Loading

changeset-bot bot commented Jan 30, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

codecov bot commented Jan 31, 2024 •

edited

Loading

magnusdahlstrand commented Jan 31, 2024 •

edited

Loading

jaaneh commented Feb 5, 2024 •

edited

Loading

jaaneh commented Feb 6, 2024 •

edited

Loading

jaaneh commented Feb 6, 2024 •

edited

Loading