Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c3: update DO example #5250

Merged
merged 2 commits into from
Jun 5, 2024
Merged

c3: update DO example #5250

merged 2 commits into from
Jun 5, 2024

Conversation

elithrar
Copy link
Contributor

@elithrar elithrar commented Mar 14, 2024

What this PR solves / how to test

Makes it clearer what a "Durable Object" is. A user using c3 or Cloudflare for the first time will have no idea. I have also moved it down the list so that "web application" (a far more common use-case) is higher.

Author has addressed the following

@elithrar elithrar self-assigned this Mar 14, 2024
Copy link

changeset-bot bot commented Mar 14, 2024

🦋 Changeset detected

Latest commit: a7a58fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@elithrar elithrar added the c3 Relating to C3 (create-cloudflare) package label Mar 14, 2024
Copy link
Contributor

github-actions bot commented Mar 14, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9384964698/npm-package-wrangler-5250

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5250/npm-package-wrangler-5250

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9384964698/npm-package-wrangler-5250 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9384964698/npm-package-create-cloudflare-5250 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9384964698/npm-package-cloudflare-kv-asset-handler-5250
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9384964698/npm-package-miniflare-5250
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9384964698/npm-package-cloudflare-pages-shared-5250
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9384964698/npm-package-cloudflare-vitest-pool-workers-5250

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.59.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240524.2
workerd 1.20240524.0 1.20240524.0
workerd --version 1.20240524.0 2024-05-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@elithrar elithrar marked this pull request as ready for review March 14, 2024 13:08
@elithrar elithrar requested a review from a team as a code owner March 14, 2024 13:09
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that the CI tests are not broken by this change, which they might as some have to use "down arrow" key presses to get to the correct item in the list when testing the interactive flow.

@petebacondarwin
Copy link
Contributor

Oh and this file needs reformatting: packages/create-cloudflare/templates/hello-world-durable-object/c3.ts

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.46%. Comparing base (2789f26) to head (bf5e3b7).
Report is 199 commits behind head on main.

Current head bf5e3b7 differs from pull request most recent head a7a58fa

Please upload reports for the commit a7a58fa to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5250      +/-   ##
==========================================
- Coverage   72.44%   71.46%   -0.99%     
==========================================
  Files         331      309      -22     
  Lines       17298    16081    -1217     
  Branches     4422     4103     -319     
==========================================
- Hits        12532    11492    -1040     
+ Misses       4766     4589     -177     

see 121 files with indirect coverage changes

@petebacondarwin petebacondarwin merged commit cfde058 into main Jun 5, 2024
24 of 27 checks passed
@petebacondarwin petebacondarwin deleted the elithrar-patch-1 branch June 5, 2024 13:47
@workers-devprod workers-devprod mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c3 Relating to C3 (create-cloudflare) package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants