-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c3: update DO example #5250
c3: update DO example #5250
Conversation
🦋 Changeset detectedLatest commit: a7a58fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9384964698/npm-package-wrangler-5250 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5250/npm-package-wrangler-5250 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9384964698/npm-package-wrangler-5250 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9384964698/npm-package-create-cloudflare-5250 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9384964698/npm-package-cloudflare-kv-asset-handler-5250 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9384964698/npm-package-miniflare-5250 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9384964698/npm-package-cloudflare-pages-shared-5250 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9384964698/npm-package-cloudflare-vitest-pool-workers-5250 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that the CI tests are not broken by this change, which they might as some have to use "down arrow" key presses to get to the correct item in the list when testing the interactive flow.
Oh and this file needs reformatting: packages/create-cloudflare/templates/hello-world-durable-object/c3.ts |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5250 +/- ##
==========================================
- Coverage 72.44% 71.46% -0.99%
==========================================
Files 331 309 -22
Lines 17298 16081 -1217
Branches 4422 4103 -319
==========================================
- Hits 12532 11492 -1040
+ Misses 4766 4589 -177 |
bf5e3b7
to
a40cc88
Compare
311b37b
to
a7a58fa
Compare
What this PR solves / how to test
Makes it clearer what a "Durable Object" is. A user using c3 or Cloudflare for the first time will have no idea. I have also moved it down the list so that "web application" (a far more common use-case) is higher.
Author has addressed the following