Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace outdated dependency for eslint plugin polyfills #5305

Closed

Conversation

harryzcy
Copy link

@harryzcy harryzcy commented Mar 19, 2024

What this PR solves / how to test

Replaces both @esbuild-plugins/node-globals-polyfill and @esbuild-plugins/node-modules-polyfill with esbuild-plugin-polyfill-node

From https://github.com/remorses/esbuild-plugins README:

Author has addressed the following

@harryzcy harryzcy requested a review from a team as a code owner March 19, 2024 21:38
Copy link

changeset-bot bot commented Mar 19, 2024

⚠️ No Changeset found

Latest commit: 7f9dcf9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@harryzcy harryzcy changed the title Replace eslint plugin polyfills with esbuild-plugin-polyfill-node Replace outdated dependency for eslint plugin polyfills Mar 19, 2024
@petebacondarwin
Copy link
Contributor

Thanks for this @harryzcy - we have already landed a PR that does this onto our v4 branch: #5209

You can try it out by:

npm i -D wrangler@next

@harryzcy harryzcy deleted the esbuild-plugin-polyfill-node branch March 19, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants