-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wrangler-d1): Teach wrangler d1 insights about more timePeriods #5307
Conversation
🦋 Changeset detectedLatest commit: 6a85760 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9466800360/npm-package-wrangler-5307 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5307/npm-package-wrangler-5307 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9466800360/npm-package-wrangler-5307 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9466800360/npm-package-create-cloudflare-5307 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9466800360/npm-package-cloudflare-kv-asset-handler-5307 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9466800360/npm-package-miniflare-5307 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9466800360/npm-package-cloudflare-pages-shared-5307 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9466800360/npm-package-cloudflare-vitest-pool-workers-5307 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5307 +/- ##
==========================================
- Coverage 72.44% 71.97% -0.48%
==========================================
Files 331 313 -18
Lines 17298 16260 -1038
Branches 4422 4165 -257
==========================================
- Hits 12532 11703 -829
+ Misses 4766 4557 -209
|
156c381
to
210f8c2
Compare
Don't worry about tests/docs in this PR - we will start documenting this command soon, but have a pretty large refactor planned. |
Thanks @rozenmd all done now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I'm sure the existing behaviour of 1d, 7d or 31d is tested and continues to work with these changes but could you add some tests for other periods please?
Just saw @rozenmd's comment – is this PR still relevant? Had the refactor landed and is this ready to land too?
Co-authored-by: Max Rozen <3822106+rozenmd@users.noreply.github.com>
Co-authored-by: Max Rozen <3822106+rozenmd@users.noreply.github.com>
@RamIdeas I've added tests - the refactor hasn't happened yet, but this would still be useful in the meantime |
What this PR solves / how to test
This PR teaches
wrangler d1 insights
about more timePeriods. The input can now be of the form\d+[dmh]
Fixes #5048
Author has addressed the following