-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate duplicate bindings across all binding types #5737
Validate duplicate bindings across all binding types #5737
Conversation
🦋 Changeset detectedLatest commit: cc87ccd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-wrangler-5737 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5737/npm-package-wrangler-5737 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-wrangler-5737 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-create-cloudflare-5737 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-kv-asset-handler-5737 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-miniflare-5737 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-pages-shared-5737 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-vitest-pool-workers-5737 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-workers-editor-shared-5737 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-workers-shared-5737 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
11deac5
to
cd5eb7a
Compare
this LGTM. Left a small comment + don't forget about adding a changeset. Otherwise, good to go |
@penalosa do we still want to land this? |
cd5eb7a
to
884210f
Compare
cdf0ade
to
a320c3b
Compare
What this PR solves / how to test
Fixes #2893
Author has addressed the following