-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pass lint/typechecks for kv-asset-handler #6102
Conversation
🦋 Changeset detectedLatest commit: 78abcde The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9594757916/npm-package-wrangler-6102 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6102/npm-package-wrangler-6102 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9594757916/npm-package-wrangler-6102 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9594757916/npm-package-create-cloudflare-6102 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9594757916/npm-package-cloudflare-kv-asset-handler-6102 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9594757916/npm-package-miniflare-6102 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9594757916/npm-package-cloudflare-pages-shared-6102 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9594757916/npm-package-cloudflare-vitest-pool-workers-6102 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
f1e3c5d
to
386796e
Compare
Followup from #6090, this enables typechecking and linting in kv-asset-handler, and fixes any failures.
386796e
to
78abcde
Compare
@@ -13,6 +13,7 @@ | |||
"src/miniflare-cli", | |||
"templates", | |||
"**/__tests__", | |||
"**/*.test.ts" | |||
"**/*.test.ts", | |||
"kv-asset-handler.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kv-asset-handler
brings in @cloudflare/workers-types
now, which we don't want included in typechecking wrangler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Sunil <3
Followup from #6090, this enables typechecking and linting in kv-asset-handler, and fixes any failures.