Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pass lint/typechecks for kv-asset-handler #6102

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

threepointone
Copy link
Contributor

Followup from #6090, this enables typechecking and linting in kv-asset-handler, and fixes any failures.

@threepointone threepointone requested a review from a team as a code owner June 20, 2024 08:31
Copy link

changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: 78abcde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cloudflare/kv-asset-handler Patch
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 20, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9594757916/npm-package-wrangler-6102

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6102/npm-package-wrangler-6102

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9594757916/npm-package-wrangler-6102 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9594757916/npm-package-create-cloudflare-6102 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9594757916/npm-package-cloudflare-kv-asset-handler-6102
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9594757916/npm-package-miniflare-6102
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9594757916/npm-package-cloudflare-pages-shared-6102
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9594757916/npm-package-cloudflare-vitest-pool-workers-6102

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.61.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.1
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@threepointone threepointone marked this pull request as draft June 20, 2024 08:41
Followup from #6090, this enables typechecking and linting in kv-asset-handler, and fixes any failures.
@threepointone threepointone marked this pull request as ready for review June 20, 2024 09:17
@@ -13,6 +13,7 @@
"src/miniflare-cli",
"templates",
"**/__tests__",
"**/*.test.ts"
"**/*.test.ts",
"kv-asset-handler.js"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kv-asset-handler brings in @cloudflare/workers-types now, which we don't want included in typechecking wrangler.

Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Sunil <3

@threepointone threepointone merged commit d4e1e9f into main Jun 20, 2024
19 checks passed
@threepointone threepointone deleted the lint-tsc-kv-asset-handler branch June 20, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants