Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wrangler): fix failing versions e2e tests #6108

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Jun 20, 2024

What this PR solves / how to test

Fixes versions e2e tests that started failing after we merged #5950

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: fixes e2e tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: fixes e2e tests

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner June 20, 2024 16:59
Copy link

changeset-bot bot commented Jun 20, 2024

⚠️ No Changeset found

Latest commit: 5e60828

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CarmenPopoviciu CarmenPopoviciu added the e2e Run e2e tests on a PR label Jun 20, 2024
Copy link
Member

@WalshyDev WalshyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty and sorry!

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9601425457/npm-package-wrangler-6108

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6108/npm-package-wrangler-6108

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9601425457/npm-package-wrangler-6108 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9601425457/npm-package-create-cloudflare-6108 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9601425457/npm-package-cloudflare-kv-asset-handler-6108
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9601425457/npm-package-miniflare-6108
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9601425457/npm-package-cloudflare-pages-shared-6108
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9601425457/npm-package-cloudflare-vitest-pool-workers-6108

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.61.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.1
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu merged commit 87eb4c6 into main Jun 20, 2024
26 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/versions-tests branch June 20, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants