print startup time in version upload #6392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 79951e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
13 tasks
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10186153781/npm-package-wrangler-6392You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6392/npm-package-wrangler-6392Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10186153781/npm-package-wrangler-6392 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10186153781/npm-package-create-cloudflare-6392 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10186153781/npm-package-cloudflare-kv-asset-handler-6392npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10186153781/npm-package-miniflare-6392npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10186153781/npm-package-cloudflare-pages-shared-6392npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10186153781/npm-package-cloudflare-vitest-pool-workers-6392Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Same as #6318 , but for version upload
Bundle size was a proxy for startup time. Now that we have startup time reported, focus on bundle size is less relevant. Tracked internally as EW-8219
taylorlee
force-pushed
the
tlee/print-startup-time
branch
from
78d5737 to
79951e8
Compare
RamIdeas
approved these changes
Jul 31, 2024
Merged
emily-shen
pushed a commit
that referenced
this pull request
Aug 6, 2024
* [wrangler] log startup time in version upload Same as #6318 , but for version upload * [wrangler] remove bundle size warning Bundle size was a proxy for startup time. Now that we have startup time reported, focus on bundle size is less relevant. Tracked internally as EW-8219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Fixes version upload missing from version upload. Similar to #6318
Removes bundle-size warning.
Repeat of #6381 but with CI
Author has addressed the following
Wait for API release with field
Tests
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
Changeset (Changeset guidelines)
Public documentation