fix: resolve npm modules correctly #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When implementing legacy module specifiers, we didn't throughly test the interaction when there weren't any other files next to the entry worker, and importing npm modules. It would create a Regex that matched _every_ import, and fail because a file of that name wasn't present in the source directory. This fix constructs a better regex, applies it only when there are more files next to the worker, and increases test coverage for that scenario. Fixes #655
🦋 Changeset detectedLatest commit: 4247ea5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2016722948/npm-package-wrangler-656You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/656/npm-package-wrangler-656Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2016722948/npm-package-wrangler-656 dev path/to/script.js |
JacobMGEvans
approved these changes
Mar 21, 2022
Merged
mrbbot
added a commit
that referenced
this pull request
Oct 31, 2023
This is a temporary fix to allow Workers Sites tests cherrypicked from #656 to pass. Listing keys in Workers Sites `__STATIC_CONTENT` namespace was previously broken, due to a type error in the inline namespace worker script. This change also means we can avoid the `Function#toString()`ing to "bundle" code in inline worker scripts.
mrbbot
added a commit
that referenced
this pull request
Oct 31, 2023
With #656, the Queues dispatcher is now implemented as part of the broker Durable Object. We no longer send message batches directly from Node.js, so can remove queue handling from the entry worker. Note the magic proxy enqueues messages through queue producer bindings like regular workers, so never used this endpoint directly.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
This is a temporary fix to allow Workers Sites tests cherrypicked from #656 to pass. Listing keys in Workers Sites `__STATIC_CONTENT` namespace was previously broken, due to a type error in the inline namespace worker script. This change also means we can avoid the `Function#toString()`ing to "bundle" code in inline worker scripts.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
With #656, the Queues dispatcher is now implemented as part of the broker Durable Object. We no longer send message batches directly from Node.js, so can remove queue handling from the entry worker. Note the magic proxy enqueues messages through queue producer bindings like regular workers, so never used this endpoint directly.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
This is a temporary fix to allow Workers Sites tests cherrypicked from #656 to pass. Listing keys in Workers Sites `__STATIC_CONTENT` namespace was previously broken, due to a type error in the inline namespace worker script. This change also means we can avoid the `Function#toString()`ing to "bundle" code in inline worker scripts.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
With #656, the Queues dispatcher is now implemented as part of the broker Durable Object. We no longer send message batches directly from Node.js, so can remove queue handling from the entry worker. Note the magic proxy enqueues messages through queue producer bindings like regular workers, so never used this endpoint directly.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
This is a temporary fix to allow Workers Sites tests cherrypicked from #656 to pass. Listing keys in Workers Sites `__STATIC_CONTENT` namespace was previously broken, due to a type error in the inline namespace worker script. This change also means we can avoid the `Function#toString()`ing to "bundle" code in inline worker scripts.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
With #656, the Queues dispatcher is now implemented as part of the broker Durable Object. We no longer send message batches directly from Node.js, so can remove queue handling from the entry worker. Note the magic proxy enqueues messages through queue producer bindings like regular workers, so never used this endpoint directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing legacy module specifiers, we didn't throughly test the interaction when there weren't any other files next to the entry worker, and importing npm modules. It would create a Regex that matched every import, and fail because a file of that name wasn't present in the source directory. This fix constructs a better regex, applies it only when there are more files next to the worker, and increases test coverage for that scenario.
Fixes #655
(ignore whitespace when reviewing this)