Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error if a user inadvertently uploads a Pages _workers.js file or directory as an asset #6762

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Sep 19, 2024

What this PR solves / how to test

Fixes WC-2726

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: covered by unit tests
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: just adding a warning

@petebacondarwin petebacondarwin requested a review from a team as a code owner September 19, 2024 09:15
Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: 880d9e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 19, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944856423/npm-package-wrangler-6762

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6762/npm-package-wrangler-6762

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944856423/npm-package-wrangler-6762 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944856423/npm-package-create-cloudflare-6762 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944856423/npm-package-cloudflare-kv-asset-handler-6762
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944856423/npm-package-miniflare-6762
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944856423/npm-package-cloudflare-pages-shared-6762
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944856423/npm-package-cloudflare-vitest-pool-workers-6762
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944856423/npm-package-cloudflare-workers-editor-shared-6762
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944856423/npm-package-cloudflare-workers-shared-6762

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.78.5 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.3
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@threepointone
Copy link
Contributor

Should this be an error instead?

@petebacondarwin
Copy link
Contributor Author

Should this be an error instead?

Good question. It might be wise to error, given that there is a path to remove the error and publishing by accident could be nasty. @tanushree-sharma thoughts?

@petebacondarwin petebacondarwin changed the title fix: add a warning if a user inadvertently uploads a Pages _workers.js file as an asset fix: error if a user inadvertently uploads a Pages _workers.js file or directory as an asset Sep 19, 2024
@petebacondarwin
Copy link
Contributor Author

Talked to @tanushree-sharma offline and we agreed to go with an error. Thanks @threepointone for the suggestion.

@petebacondarwin petebacondarwin merged commit 2840b9f into main Sep 20, 2024
22 checks passed
@petebacondarwin petebacondarwin deleted the warn-on-worker-js-asset branch September 20, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants