Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Env from index.ts #6790

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Remove Env from index.ts #6790

merged 4 commits into from
Sep 23, 2024

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Sep 20, 2024

What this PR solves / how to test

Fixes N/A

Remove the Env type from index.ts, instead relying on wrangler types

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: minor template change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: minor template change
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: minor template change

@penalosa penalosa requested review from a team as code owners September 20, 2024 15:00
Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: 023d81f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙂

LGTM 👍

Copy link
Contributor

github-actions bot commented Sep 20, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-wrangler-6790

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6790/npm-package-wrangler-6790

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-wrangler-6790 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-create-cloudflare-6790 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-cloudflare-kv-asset-handler-6790
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-miniflare-6790
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-cloudflare-pages-shared-6790
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-cloudflare-vitest-pool-workers-6790
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-cloudflare-workers-editor-shared-6790
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-cloudflare-workers-shared-6790

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.78.7 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.4
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Member

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help removing the env on packages/create-cloudflare/templates-experimental/hello-world-durable-object-with-assets/ts/src/index.ts as well?

@edmundhung edmundhung merged commit 9e44d88 into main Sep 23, 2024
27 checks passed
@edmundhung edmundhung deleted the penalosa/c3-do-env branch September 23, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants