-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Env
from index.ts
#6790
Remove Env
from index.ts
#6790
Conversation
🦋 Changeset detectedLatest commit: 023d81f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🙂
LGTM 👍
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-wrangler-6790 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6790/npm-package-wrangler-6790 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-wrangler-6790 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-create-cloudflare-6790 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-cloudflare-kv-asset-handler-6790 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-miniflare-6790 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-cloudflare-pages-shared-6790 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-cloudflare-vitest-pool-workers-6790 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-cloudflare-workers-editor-shared-6790 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994419507/npm-package-cloudflare-workers-shared-6790 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help removing the env on packages/create-cloudflare/templates-experimental/hello-world-durable-object-with-assets/ts/src/index.ts
as well?
1956a90
to
a12cf28
Compare
What this PR solves / how to test
Fixes N/A
Remove the
Env
type fromindex.ts
, instead relying onwrangler types
Author has addressed the following