Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing bindings to init --from-dash #6791

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Sep 20, 2024

What this PR solves / how to test

Fixes #6735

Adds missing bindings to init --from-dash, as well as an assertNever() type check to ensure this list doesn't get out of sync in future

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: Wrangler tests are sufficient
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

@penalosa penalosa requested a review from a team as a code owner September 20, 2024 16:27
Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: 5177e31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@penalosa penalosa changed the title Add missing binding to init --from-dash Add missing binding to init --from-dash Sep 20, 2024
@penalosa penalosa changed the title Add missing binding to init --from-dash Add missing bindings to init --from-dash Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-wrangler-6791

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6791/npm-package-wrangler-6791

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-wrangler-6791 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-create-cloudflare-6791 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-cloudflare-kv-asset-handler-6791
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-miniflare-6791
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-cloudflare-pages-shared-6791
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-cloudflare-vitest-pool-workers-6791
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-cloudflare-workers-editor-shared-6791
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-cloudflare-workers-shared-6791

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.78.7 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.4
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Comment on lines +1174 to +1181
case "version_metadata": {
{
configObj.version_metadata = {
binding: binding.name,
};
}
break;
}
Copy link
Member

@edmundhung edmundhung Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe you want this?

Suggested change
case "version_metadata": {
{
configObj.version_metadata = {
binding: binding.name,
};
}
break;
}
case "version_metadata": {
configObj.version_metadata = {
binding: binding.name,
};
break;
}

@edmundhung edmundhung merged commit 74d719f into main Sep 23, 2024
22 of 24 checks passed
@edmundhung edmundhung deleted the penalosa/expand-init-from-dash branch September 23, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: --from-dash doesn't know about the shape of all bindings
2 participants