-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing bindings to init --from-dash
#6791
Conversation
🦋 Changeset detectedLatest commit: 5177e31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
init --from-dash
init --from-dash
init --from-dash
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-wrangler-6791 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6791/npm-package-wrangler-6791 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-wrangler-6791 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-create-cloudflare-6791 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-cloudflare-kv-asset-handler-6791 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-miniflare-6791 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-cloudflare-pages-shared-6791 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-cloudflare-vitest-pool-workers-6791 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-cloudflare-workers-editor-shared-6791 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10963585069/npm-package-cloudflare-workers-shared-6791 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
case "version_metadata": { | ||
{ | ||
configObj.version_metadata = { | ||
binding: binding.name, | ||
}; | ||
} | ||
break; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: maybe you want this?
case "version_metadata": { | |
{ | |
configObj.version_metadata = { | |
binding: binding.name, | |
}; | |
} | |
break; | |
} | |
case "version_metadata": { | |
configObj.version_metadata = { | |
binding: binding.name, | |
}; | |
break; | |
} |
What this PR solves / how to test
Fixes #6735
Adds missing bindings to
init --from-dash
, as well as anassertNever()
type check to ensure this list doesn't get out of sync in futureAuthor has addressed the following