-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error when asset binding is provided without user worker #6798
Conversation
🦋 Changeset detectedLatest commit: cdc9f71 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994091735/npm-package-wrangler-6798 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6798/npm-package-wrangler-6798 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994091735/npm-package-wrangler-6798 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994091735/npm-package-create-cloudflare-6798 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994091735/npm-package-cloudflare-kv-asset-handler-6798 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994091735/npm-package-miniflare-6798 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994091735/npm-package-cloudflare-pages-shared-6798 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994091735/npm-package-cloudflare-vitest-pool-workers-6798 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994091735/npm-package-cloudflare-workers-editor-shared-6798 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10994091735/npm-package-cloudflare-workers-shared-6798 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Just a typo.
@@ -392,7 +398,8 @@ export function verifyMutuallyExclusiveAssetsArgsOrConfig( | |||
(args.legacyAssets || config.legacy_assets) | |||
) { | |||
throw new UserError( | |||
"Cannot use Experimental Assets and Legacy Assets in the same Worker." | |||
"Cannot use Experimental Assets and Legacy Assets in the same Worker.\n" + | |||
"Please remove either the `site` or `experimental_assets` field from your configuration file." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Please remove either the `site` or `experimental_assets` field from your configuration file." | |
"Please remove either the `legacy_assets` or `experimental_assets` field from your configuration file." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the wrangler.toml key for sites/legacy assets is sites
What this PR solves / how to test
Fixes WC-2744
Author has addressed the following