Skip to content

chore(create-cloudflare): add support for new bun.lock #6831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

Cherry
Copy link
Contributor

@Cherry Cherry commented Sep 26, 2024

What this PR solves / how to test

Adds support for upcoming bun.lock to detectPmMismatch method.

https://x.com/jarredsumner/status/1839056611765268651

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: covered by unit tests
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: minor addition to internals

Sorry, something went wrong.

@Cherry Cherry requested review from a team as code owners September 26, 2024 00:05
Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: e36e6bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Cherry and others added 3 commits November 12, 2024 23:35
@penalosa penalosa force-pushed the chore/bun-lockfile-new branch from 5e14ae1 to e36e6bf Compare November 12, 2024 23:35
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11807604483/npm-package-wrangler-6831

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6831/npm-package-wrangler-6831

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11807604483/npm-package-wrangler-6831 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11807604483/npm-package-create-cloudflare-6831 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11807604483/npm-package-cloudflare-kv-asset-handler-6831
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11807604483/npm-package-miniflare-6831
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11807604483/npm-package-cloudflare-pages-shared-6831
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11807604483/npm-package-cloudflare-vitest-pool-workers-6831
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11807604483/npm-package-cloudflare-workers-editor-shared-6831
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11807604483/npm-package-cloudflare-workers-shared-6831
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11807604483/npm-package-cloudflare-workflows-shared-6831

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.86.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit 0fe018c into cloudflare:main Nov 18, 2024
27 of 28 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Nov 18, 2024
Copy link

holopin-bot bot commented Nov 18, 2024

Congratulations @Cherry, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm3n488x623020cjmz23y2mn3

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants