Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-cloudflare): update experimental remix template to be based on its worker template #7170

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

edmundhung
Copy link
Member

Fixes n/a.

This PR updates the experimental remix template to be based on its worker template.
Ref: remix-run/remix#10034


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: No feature change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: template config change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: No feature change

Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: 270b9e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688743310/npm-package-wrangler-7170

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7170/npm-package-wrangler-7170

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688743310/npm-package-wrangler-7170 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688743310/npm-package-create-cloudflare-7170 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688743310/npm-package-cloudflare-kv-asset-handler-7170
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688743310/npm-package-miniflare-7170
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688743310/npm-package-cloudflare-pages-shared-7170
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688743310/npm-package-cloudflare-vitest-pool-workers-7170
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688743310/npm-package-cloudflare-workers-editor-shared-7170
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688743310/npm-package-cloudflare-workers-shared-7170
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688743310/npm-package-cloudflare-workflows-shared-7170

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.84.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 🤩 Awesome work @edmundhung 🫶 🚀

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@petebacondarwin petebacondarwin merged commit f292294 into main Nov 7, 2024
30 checks passed
@petebacondarwin petebacondarwin deleted the edmundhung/c3-remix-worker-template branch November 7, 2024 12:30
@workers-devprod workers-devprod mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants