Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Queues] Output suggested wrangler.toml changes after creating a Queue #7191

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

sdnts
Copy link
Contributor

@sdnts sdnts commented Nov 7, 2024

Fixes #MQ-800.

Outputs suggested wrangler.toml changes after creating a Queue


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: captured by unit tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this changes what we log after creating a Queue

@sdnts sdnts requested a review from a team as a code owner November 7, 2024 15:16
Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: b77b52d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 7, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728493190/npm-package-wrangler-7191

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7191/npm-package-wrangler-7191

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728493190/npm-package-wrangler-7191 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728493190/npm-package-create-cloudflare-7191 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728493190/npm-package-cloudflare-kv-asset-handler-7191
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728493190/npm-package-miniflare-7191
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728493190/npm-package-cloudflare-pages-shared-7191
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728493190/npm-package-cloudflare-vitest-pool-workers-7191
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728493190/npm-package-cloudflare-workers-editor-shared-7191
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728493190/npm-package-cloudflare-workers-shared-7191
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728493190/npm-package-cloudflare-workflows-shared-7191

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.85.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@sdnts sdnts force-pushed the siddhant/queues-create-hint branch from 3250d52 to 2764b61 Compare November 7, 2024 15:49
Copy link
Contributor

@toddmantell toddmantell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sdnts sdnts force-pushed the siddhant/queues-create-hint branch from 2764b61 to b77b52d Compare November 7, 2024 17:49
@CarmenPopoviciu CarmenPopoviciu merged commit 1d5bc6d into cloudflare:main Nov 7, 2024
17 checks passed
@workers-devprod workers-devprod mentioned this pull request Nov 7, 2024
@sdnts sdnts deleted the siddhant/queues-create-hint branch November 7, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants