Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Version Preview URL in Wrangler output file #7243

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

penalosa
Copy link
Contributor

Fixes #7240

Include the version preview URL from wrangler versions upload in Wrangler's output file.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Wrangler's output file is not currently documented

@penalosa penalosa requested a review from a team as a code owner November 12, 2024 18:48
Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: 837c534

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Nov 12, 2024
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11803766130/npm-package-wrangler-7243

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7243/npm-package-wrangler-7243

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11803766130/npm-package-wrangler-7243 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11803766130/npm-package-create-cloudflare-7243 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11803766130/npm-package-cloudflare-kv-asset-handler-7243
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11803766130/npm-package-miniflare-7243
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11803766130/npm-package-cloudflare-pages-shared-7243
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11803766130/npm-package-cloudflare-vitest-pool-workers-7243
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11803766130/npm-package-cloudflare-workers-editor-shared-7243
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11803766130/npm-package-cloudflare-workers-shared-7243
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11803766130/npm-package-cloudflare-workflows-shared-7243

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.86.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit 941d411 into main Nov 18, 2024
37 of 38 checks passed
@penalosa penalosa deleted the penalosa/include-version-preview branch November 18, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: Write Version Preview URL to artifacts file
4 participants