Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate r2 commands to new command registration setup #7311

Merged
merged 40 commits into from
Nov 22, 2024

Conversation

edmundhung
Copy link
Member

Fixes n/a.

Related #6655


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: refactor
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: refactor

@edmundhung edmundhung added e2e Run e2e tests on a PR no-changeset-required labels Nov 21, 2024
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: f9e4fc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11959961148/npm-package-wrangler-7311

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7311/npm-package-wrangler-7311

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11959961148/npm-package-wrangler-7311 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11959961148/npm-package-create-cloudflare-7311 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11959961148/npm-package-cloudflare-kv-asset-handler-7311
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11959961148/npm-package-miniflare-7311
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11959961148/npm-package-cloudflare-pages-shared-7311
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11959961148/npm-package-cloudflare-vitest-pool-workers-7311
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11959961148/npm-package-cloudflare-workers-editor-shared-7311
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11959961148/npm-package-cloudflare-workers-shared-7311
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11959961148/npm-package-cloudflare-workflows-shared-7311

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.89.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung marked this pull request as ready for review November 21, 2024 17:52
@edmundhung edmundhung requested a review from a team as a code owner November 21, 2024 17:52
@edmundhung edmundhung force-pushed the edmundhung/refactor-r2-commands branch from 9146683 to f9e4fc8 Compare November 21, 2024 19:06
@edmundhung edmundhung merged commit c650cc9 into main Nov 22, 2024
32 checks passed
@edmundhung edmundhung deleted the edmundhung/refactor-r2-commands branch November 22, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR no-changeset-required
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants