Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wrangler): identify draft and inherit bindings #7427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Dec 3, 2024

Fixes DEVX-1421.

This PR adds the ability to identify draft and inherit bindings by looking up the current binding settings.

It is based on the changes on #7385 with 1 new commit 04b5b5b. Please rebase it once #7385 is merged.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: unreleased feature

@edmundhung edmundhung requested review from a team as code owners December 3, 2024 16:28
Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: df63c84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 3, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12159038978/npm-package-wrangler-7427

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7427/npm-package-wrangler-7427

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12159038978/npm-package-wrangler-7427 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12159038978/npm-package-create-cloudflare-7427 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12159038978/npm-package-cloudflare-kv-asset-handler-7427
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12159038978/npm-package-miniflare-7427
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12159038978/npm-package-cloudflare-pages-shared-7427
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12159038978/npm-package-cloudflare-vitest-pool-workers-7427
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12159038978/npm-package-cloudflare-workers-editor-shared-7427
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12159038978/npm-package-cloudflare-workers-shared-7427
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12159038978/npm-package-cloudflare-workflows-shared-7427

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.92.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.2
workerd 1.20241106.2 1.20241106.2
workerd --version 1.20241106.2 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung added the e2e Run e2e tests on a PR label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant