Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax type on observability.enabled #7436

Merged
merged 3 commits into from
Dec 4, 2024
+7 −2
Merged

Relax type on observability.enabled #7436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f0aa16
Merge branch 'main' of https://github.com/Ankcorn/workers-sdk
Ankcorn Nov 20, 2024
608988a
Merge branch 'main' of https://github.com/Ankcorn/workers-sdk
Ankcorn Dec 4, 2024
3bfef91
Relax type on observability.enabled
Ankcorn Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unlucky-teachers-call.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

Relax type on observability.enabled to remove linting error for nested configurations
4 changes: 2 additions & 2 deletions packages/wrangler/src/config/environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,11 +953,11 @@ export type Assets = {

export interface Observability {
/** If observability is enabled for this Worker */
enabled: boolean;
enabled?: boolean;
/** The sampling rate */
head_sampling_rate?: number;
logs?: {
enabled: boolean;
enabled?: boolean;
/** The sampling rate */
head_sampling_rate?: number;
/** Set to false to disable invocation logs */
Expand Down
Loading