Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Ensure that unstable type exports are all prefixed with Unstable_ rather than just Unstable #7454

Merged
merged 1 commit into from
Dec 5, 2024
Merged

refactor: Ensure that unstable type exports are all prefixed with Unstable_ rather than just Unstable #7454

merged 1 commit into from
Dec 5, 2024

Conversation

petebacondarwin
Copy link
Contributor

Fixes #0000

We use unstable_ as a prefix for experimental/unstable functions, but we were using just Unstable without the underscore as a prefix for types.

This change ensures that all unstable type exports are prefixed with Unstable_ rather than just Unstable.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: refactor

@petebacondarwin petebacondarwin requested a review from a team as a code owner December 5, 2024 14:30
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 5771e27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin added the e2e Run e2e tests on a PR label Dec 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-wrangler-7454

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7454/npm-package-wrangler-7454

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-wrangler-7454 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-create-cloudflare-7454 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-cloudflare-kv-asset-handler-7454
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-miniflare-7454
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-cloudflare-pages-shared-7454
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-cloudflare-vitest-pool-workers-7454
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-cloudflare-workers-editor-shared-7454
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-cloudflare-workers-shared-7454
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-cloudflare-workflows-shared-7454

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.92.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.2
workerd 1.20241106.2 1.20241106.2
workerd --version 1.20241106.2 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit f2045be into main Dec 5, 2024
36 of 37 checks passed
@penalosa penalosa deleted the pbd/update-unstable-type-exports-prefix branch December 5, 2024 17:06
@workers-devprod workers-devprod mentioned this pull request Dec 5, 2024
Merged
penalosa added a commit that referenced this pull request Dec 6, 2024
@penalosa
Squashed commit of the following:
f0fc7bd 
commit 094699c6a218caa1c0ed5dcfb8f75598bc1f503c
Merge: 21bfe2a5b 5ea9d8e
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Fri Dec 6 00:36:04 2024 +0000

    Merge remote-tracking branch 'origin/main' into penalosa/extension-scaffolding

commit 21bfe2a5b2f43c4d505cde795a2958964c4a8b0a
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Fri Dec 6 00:36:00 2024 +0000

    main

commit 5ea9d8e
Author: emily-shen <69125074+emily-shen@users.noreply.github.com>
Date:   Thu Dec 5 19:01:47 2024 +0000

    remove stray await (#7453)

commit 9ede45b
Author: Pete Bacon Darwin <pete@bacondarwin.com>
Date:   Thu Dec 5 18:45:35 2024 +0000

    fix: relax validation of unsafe configuration to allow an empty object (#7461)

    The types, the default and the code in general support an empty object for this config setting.

    So it makes sense to avoid erroring when validating the config.

commit 55ec38a
Author: James Ross <james@jross.me>
Date:   Thu Dec 5 17:26:12 2024 +0000

    chore: bump vitest in templates (#7384)

    * chore: bump vitest in templates

    * chore: pin to vitest 2.1.5

    This works around vitest-dev/vitest#6992 being an issue with Vite 6

    * Create eighty-lies-sort.md

    * chore: update to vitest 2.1.8

    * Bump package vitest version to 2.1.8

commit f2045be
Author: Pete Bacon Darwin <pete@bacondarwin.com>
Date:   Thu Dec 5 17:06:31 2024 +0000

    refactor: Ensure that unstable type exports are all prefixed with `Unstable_` rather than just `Unstable` (#7454)

commit bc0a980
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Thu Oct 3 18:10:07 2024 +0100

    fix buikd

commit 76afe01
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Thu Oct 3 17:58:21 2024 +0100

    packaging & icon

commit cc00903
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Thu Oct 3 17:30:21 2024 +0100

    support new workers

commit 472b15d
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Thu Oct 3 17:27:18 2024 +0100

    lockfile

commit adb2f57
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Mon Sep 23 13:45:06 2024 +0100

    WIP types

commit 72f2f99
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Fri Sep 6 18:18:16 2024 +0100

    import -> require

commit 853e030
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Fri Sep 6 18:04:30 2024 +0100

    better comment

commit 7dc9c53
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Fri Sep 6 18:00:15 2024 +0100

    better comment

commit b8c8e32
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Fri Sep 6 17:52:58 2024 +0100

    build wrangler

commit 6fd3a45
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Fri Sep 6 17:35:42 2024 +0100

    vsce deps

commit 5e0df56
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Fri Sep 6 17:12:11 2024 +0100

    fix types

commit 9e8960d
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Mon Sep 2 12:03:39 2024 +0100

    sdk

commit 7ec1eed
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Fri Aug 30 22:33:20 2024 +0100

    api

commit c6462ec
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Fri Aug 9 20:51:13 2024 +0100

    fix build

commit 1bc79d4
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Fri Aug 9 20:44:17 2024 +0100

    fix lint

commit f544b2a
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Fri Aug 9 20:36:21 2024 +0100

    Resource provisioning

commit eb48c7c
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Fri Aug 30 20:33:39 2024 +0100

    a bit more

commit d2eef9f
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Thu Aug 29 19:00:55 2024 +0100

    add caching

commit 85aebb2
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Thu Aug 29 18:59:38 2024 +0100

    path

commit fd031f6
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Thu Aug 29 18:56:55 2024 +0100

    json

commit 5c2836e
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Thu Aug 29 18:51:45 2024 +0100

    version number

commit 1999b27
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Thu Aug 29 18:41:24 2024 +0100

    update lockfile

commit c67eba1
Author: Samuel Macleod <smacleod@cloudflare.com>
Date:   Thu Aug 29 18:31:43 2024 +0100

    first pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penalosa penalosa penalosa approved these changes

@jamesopstad jamesopstad jamesopstad approved these changes

Assignees
No one assigned
Labels
e2e Run e2e tests on a PR
Projects
workers-sdk
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petebacondarwin @jamesopstad @penalosa