-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudchamber/create: always print deployment and placement ID #7523
Conversation
|
We currently only print the full deployment ID when the deployment has an IPv4 address. This commit makes the deployment ID always print, as well as the placement ID. We also move the printing of the IPv4 address (if one exists) to the same place as the IPv6 address so that they are printed together. There are a few other nit-picky changes as well. I've tried to make capitalization of labels more consistent (there doesn't appear to be a rule on when someone should be capitalized and when it shouldn't be, but I've at least made it more consistent within the subcommands themselves). I also changed the green "SUCCESS" message to only print once at the very end of the `cloudchamber create` command. This is consistent with the flow for creating a Worker.
cb3ab63
to
026b0e2
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12280153925/npm-package-wrangler-7523 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7523/npm-package-wrangler-7523 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12280153925/npm-package-wrangler-7523 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12280153925/npm-package-create-cloudflare-7523 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12280153925/npm-package-cloudflare-kv-asset-handler-7523 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12280153925/npm-package-miniflare-7523 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12280153925/npm-package-cloudflare-pages-shared-7523 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12280153925/npm-package-cloudflare-vitest-pool-workers-7523 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12280153925/npm-package-cloudflare-workers-editor-shared-7523 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12280153925/npm-package-cloudflare-workers-shared-7523 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12280153925/npm-package-cloudflare-workflows-shared-7523 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
@gpanders while these are indeed just some UI adjustments, I would have expected some existing tests to capture the changes. Are there no tests at all that capture these codepaths? |
We don't (currently) have any tests for the interactive flow for creating a deployment, which is what this PR changes. Our existing tests cover non-interactive creation and error cases, neither of which are affected by this PR. |
We currently only print the full deployment ID when the deployment has an IPv4 address. This commit makes the deployment ID always print, as well as the placement ID. We also move the printing of the IPv4 address (if one exists) to the same place as the IPv6 address so that they are printed together.
There are a few other nit-picky changes as well. I've tried to make capitalization of labels more consistent (there doesn't appear to be a rule on when someone should be capitalized and when it shouldn't be, but I've at least made it more consistent within the subcommands themselves). I also changed the green "SUCCESS" message to only print once at the very end of the
cloudchamber create
command. This is consistent with the flow for creating a Worker.