Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix broken e2e tests from merge error #7675

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

emily-shen
Copy link
Contributor

An old warning about remote dev with assets snuck in via #7533 and broke e2e tests.
(#7533 didn't need an e2e run, so it wasn't caught there)


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: test fix
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: test fix

@emily-shen emily-shen requested a review from a team as a code owner January 6, 2025 13:42
Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: 405ff17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@emily-shen emily-shen added no-changeset-required e2e Run wrangler e2e tests on a PR labels Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12633592511/npm-package-wrangler-7675

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7675/npm-package-wrangler-7675

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12633592511/npm-package-wrangler-7675 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12633592511/npm-package-cloudflare-workers-bindings-extension-7675 -O ./cloudflare-workers-bindings-extension.0.0.0-v84d91ce10.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v84d91ce10.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12633592511/npm-package-create-cloudflare-7675 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12633592511/npm-package-cloudflare-kv-asset-handler-7675
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12633592511/npm-package-miniflare-7675
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12633592511/npm-package-cloudflare-pages-shared-7675
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12633592511/npm-package-cloudflare-unenv-preset-7675
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12633592511/npm-package-cloudflare-vitest-pool-workers-7675
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12633592511/npm-package-cloudflare-workers-editor-shared-7675
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12633592511/npm-package-cloudflare-workers-shared-7675
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12633592511/npm-package-cloudflare-workflows-shared-7675

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.99.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241218.0
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen merged commit f5b3fb5 into main Jan 6, 2025
41 of 43 checks passed
@emily-shen emily-shen deleted the emily/fix-e2es branch January 6, 2025 14:19
penalosa pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR no-changeset-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants