Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vitest-pool-workers): test intercepting fetch with different query pattern #7682

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Jan 6, 2025

Fixes n/a.

Tested a few more cases around different query interception as suggested by @Skye-31 on #7668 (comment)


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: Adding extra tests only
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Adding extra tests only

Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: 9d0a056

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 6, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12639992018/npm-package-wrangler-7682

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7682/npm-package-wrangler-7682

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12639992018/npm-package-wrangler-7682 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12639992018/npm-package-cloudflare-workers-bindings-extension-7682 -O ./cloudflare-workers-bindings-extension.0.0.0-vfefca40e4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vfefca40e4.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12639992018/npm-package-create-cloudflare-7682 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12639992018/npm-package-cloudflare-kv-asset-handler-7682
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12639992018/npm-package-miniflare-7682
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12639992018/npm-package-cloudflare-pages-shared-7682
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12639992018/npm-package-cloudflare-unenv-preset-7682
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12639992018/npm-package-cloudflare-vitest-pool-workers-7682
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12639992018/npm-package-cloudflare-workers-editor-shared-7682
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12639992018/npm-package-cloudflare-workers-shared-7682
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12639992018/npm-package-cloudflare-workflows-shared-7682

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.99.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241218.0
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung changed the title chore: add test for intercepting fetch with single query chore(vitest-pool-workers): test intercepting fetch with different query pattern Jan 6, 2025
@edmundhung edmundhung marked this pull request as ready for review January 6, 2025 20:46
@edmundhung edmundhung merged commit 69ec448 into main Jan 7, 2025
36 of 39 checks passed
@edmundhung edmundhung deleted the edmundhung/vitest-fetch-mock-tests branch January 7, 2025 10:49
penalosa pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants