polish: improve consistency of warnings and errors

[petebacondarwin]

Related to #377

[changeset-bot]

🦋 Changeset detected

Latest commit: c5e7ba6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2232298793/npm-package-wrangler-848

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/848/npm-package-wrangler-848

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2232298793/npm-package-wrangler-848 dev path/to/script.js

[threepointone]

Ooh that tower of icons looks a bit imposing, no?

[JacobMGEvans]

Ooh that tower of icons looks a bit imposing, no?

I think this could be refined, but I don't feel it is imposing. Possible layout and formatting?

----------------------------

⚠️ WARNINGS: 
- stuff 
- more stuff 

-----------------------------

❌ ERRORS/DEPRECATIONS: 
- bad stuff
- more bad stuff

[petebacondarwin]

Ooh that tower of icons looks a bit imposing, no?

I actually like how it clearly delineates the warnings and errors from the informative messages, which have no icon.
In most cases there should be no errors, so you would not see any Xs.
In many cases there should be no warnings. And if there are it is nice to know where the warning ends and the other messages start.

[petebacondarwin]

The layout suggested by @JacobMGEvans could only be generated if we captured the calls to logger and only rendered them at some point (?) once they had all been completed.
We already do this, effectively, with validation warnings and errors because they are captured in Diagnostics messages, which are then all rendered together after validation completes.

We could add headers to the messages output for validation, though...

[petebacondarwin]

I updated to use the esbuild formatter. I am not sure it is any better but open to opinions...

[threepointone]

I like this better!

[petebacondarwin]

OK let's go with this. I just need to work out how to fix the Windows snapshots 😿

[petebacondarwin]

I will follow up with a PR to change the mocking to mock the logger rather than the console