Stop unnecessarily amalgamating duplicate headers in Functions #880
Conversation
GregBrimble
requested review from
threepointone and
petebacondarwin
as code owners
🦋 Changeset detectedLatest commit: 9e7828c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2264997836/npm-package-wrangler-880You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/880/npm-package-wrangler-880Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2264997836/npm-package-wrangler-880 dev path/to/script.js |
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
| @@ -132,7 +132,7 @@ export default function (pluginArgs) { | |||
| // https://fetch.spec.whatwg.org/#null-body-status | |||
| return new Response( | |||
| [101, 204, 205, 304].includes(response.status) ? null : response.body, | |||
| response | |||
| { ...response, headers: new Headers(response.headers) } | |||
There was a problem hiding this comment.
So this is the fix?
And the other change is just for consistency?
Or is the other change also fixing something?
There was a problem hiding this comment.
The bug was introduced in template-worker.ts. And template-plugin.ts was updated for consistency. Both places should now offer mutable headers and keep any duplicate headers.
Replaces #872 .
Previously,
set-cookiemulitple headers would be combined because of unexpected behavior in the spec.See previous PR for details.
Unfortunately, not easily testable because of cloudflare/miniflare#183.