CI/CD Improvements #170

JacobMGEvans · 2021-12-14T15:35:53Z

CI/CD Release Workflow & other improvements

Tests run before other workflows

To be sure that Tests and type checking is occurring on code before it is merged and released other workflows have the Testing workflow as a trigger. For example the Tests need to complete and be successful before the prerelease will run.

Release flow triggered on PR's closed

Whenever the a PR is closed/merged the Workflow will trigger for checking for a changeset and adding it to the changeset "Version" PR, when the "Version" PR is closed/merged it will trigger a release.

Consolidated old workflows as jobs in new workflows

Combined the old workflows with new workflows that have similar behavior & shared similar event triggers.

JacobMGEvans · 2021-12-17T17:27:14Z

@petebacondarwin mind taking a look at this PR

petebacondarwin

I think we can piggy back on a lot of the learning from the wrangler2 project from the last few days.

.github/workflows/release.yml

.github/workflows/typechecks.yml

threepointone · 2021-12-17T17:49:34Z

We also have to make changes to the way the automated types are generated internally to include a changeset.

JacobMGEvans · 2021-12-17T18:13:45Z

We also have to make changes to the way the automated types are generated internally to include a changeset.

I will make the necessary changes for the current changes, however, I will hold off on the PR then until we can talk more about this.

JacobMGEvans · 2022-01-05T22:07:19Z

We also have to make changes to the way the automated types are generated internally to include a changeset.

@threepointone There are two possible ways to do this from what I can tell.

So I have looked at the code in the edgeworker that does the "publish" (PR creation) it uses Octokit, I can figure out how to use that API to include a changeset. Might involve adding changesets creation to step 2, where the files are added/generated
Create a GH Action that runs on these particular PRs to create a changeset using NPX.

threepointone

Dropped some suggestions

.github/workflows/release.yml

.github/workflows/typechecks.yml

.changeset/config.json

.github/workflows/typechecks.yml

JacobMGEvans · 2022-01-12T20:35:30Z

We also have to make changes to the way the automated types are generated internally to include a changeset.

Internal PR merged for changesets

package.json

.github/workflows/typechecks.yml

package.json

.github/workflows/release.yml

threepointone

I think we need to recommend adding the prettier extension, and format on save, so people don't get frustrated when they try to send a PR. Copy relevant bits from https://github.com/cloudflare/wrangler2/tree/main/.vscode?

package.json

JacobMGEvans · 2022-01-13T15:13:14Z

And why shouldn't we run prettier on all files?

I am gonna set up Prettier to run on all of the files 👍🏻

- Added Changeset PR creation & publish Workflows - Added Typechecking workflow - Consolidated old workflows as jobs in new workflows removed build from Testing CI/CD

… working for Changesets and triggering events

…ngler2 GH Actions

- Markdownlint required a global or NPX implementation in CI - Prettier configs tweaked to minimize changes to Markdown docs

Co-authored-by: Sunil Pai <spai@cloudflare.com>

…recs and formatter default, updated gitignore

.changeset/config.json

threepointone

I think this looks good, so let's land it and see.

JacobMGEvans changed the title ~~CI/CD Improvements:~~ CI/CD Improvements Dec 14, 2021

JacobMGEvans requested a review from threepointone December 14, 2021 15:37

JacobMGEvans marked this pull request as draft December 14, 2021 23:04

JacobMGEvans force-pushed the feat/workflows-changsets branch from 4bc955a to 01c02ee Compare December 15, 2021 21:45

JacobMGEvans marked this pull request as ready for review December 15, 2021 21:46

JacobMGEvans force-pushed the feat/workflows-changsets branch from 01c02ee to b17d066 Compare December 15, 2021 21:52

petebacondarwin suggested changes Dec 17, 2021

View reviewed changes

JacobMGEvans force-pushed the feat/workflows-changsets branch from caf8ee5 to c0b63b3 Compare January 3, 2022 21:40

threepointone suggested changes Jan 5, 2022

View reviewed changes

JacobMGEvans force-pushed the feat/workflows-changsets branch 4 times, most recently from 2bec861 to 66aab9d Compare January 6, 2022 18:08

JacobMGEvans requested a review from threepointone January 12, 2022 20:34

threepointone reviewed Jan 12, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

threepointone reviewed Jan 12, 2022

View reviewed changes

.github/workflows/typechecks.yml Show resolved Hide resolved

JacobMGEvans force-pushed the feat/workflows-changsets branch from 9ffec28 to 9674d68 Compare January 12, 2022 20:59

JacobMGEvans requested a review from threepointone January 12, 2022 21:00

threepointone reviewed Jan 12, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

threepointone reviewed Jan 12, 2022

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

JacobMGEvans force-pushed the feat/workflows-changsets branch 2 times, most recently from 73e3093 to 243d358 Compare January 12, 2022 21:08

JacobMGEvans requested a review from threepointone January 12, 2022 21:31

threepointone reviewed Jan 13, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

Jacob and others added 8 commits January 13, 2022 11:41

CI/CD Improvements:

c6e8c12

- Added Changeset PR creation & publish Workflows - Added Typechecking workflow - Consolidated old workflows as jobs in new workflows removed build from Testing CI/CD

Workflow changes made to match known Wrangler2 CI/CD changes that are…

5c19f78

… working for Changesets and triggering events

Updates to the workflow from improvements and things learned from Wra…

1ecef50

…ngler2 GH Actions

PR review fixups

f4cdd18

Prettier replace of markdownlint

57339a7

- Markdownlint required a global or NPX implementation in CI - Prettier configs tweaked to minimize changes to Markdown docs

Prettier ran locally to confirm changes and configuration

54f11e4

changes per PR discussion moving linting/prettier to same job

c1fe542

Update package.json

3e9f3bd

Co-authored-by: Sunil Pai <spai@cloudflare.com>

JacobMGEvans force-pushed the feat/workflows-changsets branch from a50eac0 to ca6f6e5 Compare January 13, 2022 17:48

removed the ignore from prettier command, added .vscode settings for …

385ebf8

…recs and formatter default, updated gitignore

JacobMGEvans force-pushed the feat/workflows-changsets branch from ca6f6e5 to 385ebf8 Compare January 13, 2022 17:55

JacobMGEvans requested a review from threepointone January 13, 2022 18:09

JacobMGEvans commented Jan 13, 2022

View reviewed changes

.changeset/config.json Outdated Show resolved Hide resolved

update autogenerated changeset settings

4d638ba

threepointone approved these changes Jan 13, 2022

View reviewed changes

JacobMGEvans merged commit 771ce75 into master Jan 13, 2022

JacobMGEvans deleted the feat/workflows-changsets branch January 13, 2022 21:48

github-actions bot mentioned this pull request Jan 18, 2022

Version Packages #183

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI/CD Improvements #170

CI/CD Improvements #170

JacobMGEvans commented Dec 14, 2021 •

edited

Loading

JacobMGEvans commented Dec 17, 2021 •

edited

Loading

petebacondarwin left a comment

threepointone commented Dec 17, 2021

JacobMGEvans commented Dec 17, 2021

JacobMGEvans commented Jan 5, 2022

threepointone left a comment

JacobMGEvans commented Jan 12, 2022

threepointone left a comment

JacobMGEvans commented Jan 13, 2022

threepointone left a comment

CI/CD Improvements #170

CI/CD Improvements #170

Conversation

JacobMGEvans commented Dec 14, 2021 • edited Loading

CI/CD Release Workflow & other improvements

Tests run before other workflows

Release flow triggered on PR's closed

Consolidated old workflows as jobs in new workflows

JacobMGEvans commented Dec 17, 2021 • edited Loading

petebacondarwin left a comment

Choose a reason for hiding this comment

threepointone commented Dec 17, 2021

JacobMGEvans commented Dec 17, 2021

JacobMGEvans commented Jan 5, 2022

threepointone left a comment

Choose a reason for hiding this comment

JacobMGEvans commented Jan 12, 2022

threepointone left a comment

Choose a reason for hiding this comment

JacobMGEvans commented Jan 13, 2022

threepointone left a comment

Choose a reason for hiding this comment

JacobMGEvans commented Dec 14, 2021 •

edited

Loading

JacobMGEvans commented Dec 17, 2021 •

edited

Loading