Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wrangler deploy artifacts for deployment URLs #311

Open
tsteckenborn opened this issue Oct 25, 2024 · 1 comment
Open

Use wrangler deploy artifacts for deployment URLs #311

tsteckenborn opened this issue Oct 25, 2024 · 1 comment
Labels

Comments

@tsteckenborn
Copy link

Hi all,
I was wondering why I see some of my environment variables as deployment urls. I would argue that the coding here is not robust enough as I now always get, for example, the posthog endpoint I set as a variable (because it may be us or eu) as my deployment url:

// If this is a workers or pages deployment, try to extract the deployment URL
let deploymentUrl = "";
const deploymentUrlMatch = stdOut.match(/https?:\/\/[a-zA-Z0-9-./]+/);
if (deploymentUrlMatch && deploymentUrlMatch[0]) {
deploymentUrl = deploymentUrlMatch[0].trim();
setOutput("deployment-url", deploymentUrl);
}

Would be nice if this could be improved.

@nprogers
Copy link

This is a bug where wrangler-action is picking up the first url listed in environment variables. We need to create a PR to use deployment metadata instead. Updating this issue to reflect what work needs to be done.

@nprogers nprogers changed the title Incorrect deployment URL set Use wrangler deploy artifacts for deployment URLs Nov 12, 2024
Southpaw1496 added a commit to QuiltMC/quiltmc.org that referenced this issue Nov 29, 2024
…)"

This reverts commit fd8b3a5. The world wasn't ready (I think it's cloudflare/wrangler-action#311).

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants