Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support many package managers #166

Merged
merged 15 commits into from
Sep 18, 2023
Merged

Support many package managers #166

merged 15 commits into from
Sep 18, 2023

Conversation

nix6839
Copy link
Contributor

@nix6839 nix6839 commented Sep 1, 2023 •
edited
Loading

We must choose whether to install the package manager in this action or leave it up to the user.

Maybe fix #156

@nix6839 nix6839 requested a review from a team as a code owner September 1, 2023 21:51
@JacobMGEvans JacobMGEvans self-assigned this Sep 12, 2023
JacobMGEvans
JacobMGEvans suggested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a changeset by using npx changeset

@nix6839 nix6839 changed the title Support many package manager Support many package managers Sep 18, 2023
@JacobMGEvans
Copy link
Contributor

My change will also allow the CI to run.

@JacobMGEvans
Copy link
Contributor

This test in the branch I made to run CI (with my permissions for GH Auth Token) is showing the Environments E2E tests are failing now.

https://github.com/cloudflare/wrangler-action/actions/runs/6225473338/job/16895989165

@nix6839
Copy link
Contributor Author

nix6839 commented Sep 18, 2023

@JacobMGEvans Can you please allow CI again? I want to see error message.

@JacobMGEvans
Copy link
Contributor

JacobMGEvans commented Sep 18, 2023 •
edited
Loading

@JacobMGEvans Can you please allow CI again? I want to see error message.

It is the error in the link in my comment. Its running CI in a separate branch because even if I approve this one it will fail since the GitHub Token requires a maintainer's PR to run.

This is the link: https://github.com/cloudflare/wrangler-action/actions/runs/6225473338/job/16895989165

@nix6839
Copy link
Contributor Author

nix6839 commented Sep 18, 2023

Is there anything I can do about it now?

@JacobMGEvans
Copy link
Contributor

JacobMGEvans commented Sep 18, 2023 •
edited
Loading

Is there anything I can do about it now?

Figure out why your changes caused the Environment E2E's to fail, the action can be tested/developed locally with https://github.com/nektos/act

If you don't I am sure someone will pick up the PR, if not me.

@nix6839
Copy link
Contributor Author

nix6839 commented Sep 18, 2023 •
edited
Loading

@JacobMGEvans I fixed it.

P.S. act is awesome! Thanks for letting me know about that!

JacobMGEvans
JacobMGEvans approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great initial implementation and covers some of the major package managers in the JS/TS ecosystem! Thanks for the hard work 😄

@JacobMGEvans JacobMGEvans merged commit 13d7075 into cloudflare:main Sep 18, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Sep 18, 2023
Merged
@AdiRishi AdiRishi mentioned this pull request Sep 21, 2023
Closed
klutchell added a commit to product-os/flowzone that referenced this pull request Oct 4, 2023
@klutchell
Specify packageManager input for latest wranger action
11fdfbe 
Change-type: patch
See: cloudflare/wrangler-action#166
@klutchell klutchell mentioned this pull request Oct 4, 2023
Merged
klutchell added a commit to product-os/flowzone that referenced this pull request Oct 4, 2023
@klutchell
Specify packageManager input for latest wranger action
b9acf59 
Change-type: patch
See: cloudflare/wrangler-action#166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobMGEvans JacobMGEvans JacobMGEvans approved these changes

Assignees

@JacobMGEvans JacobMGEvans

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v3 does not work with other package managers
2 participants
@nix6839 @JacobMGEvans