This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
feat: message if wrangler needs updating #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
force-pushed
the
avery/check-for-updates
branch
2 times, most recently
from
fcc8937 to
fd30320
Compare
|
Since there aren't tests yet could we add an undocumented/temp option to turn this off incase it breaks anyone? It could live in We could remove this later once we know users aren't irritated by it Just an idea. LGTM either way |
exvuma
reviewed
Apr 3, 2020
EverlastingBugstopper
force-pushed
the
avery/check-for-updates
branch
from
fd30320 to
7205a94
Compare
This was referenced May 1, 2020
ashleymichal
previously requested changes
May 6, 2020
|
so the only thing that needs to be done with this is making it only message once every 24 hours. right now, if your version of wrangler needs updating, it will print a message telling you to update after every single command. this shouldn't happen. Let's only bug folks about it once a day. |
Made version check only happen once a day
ashleymichal
suggested changes
May 27, 2020
Fetches latest version if version file is older than a day
src/version/mod.rs
Outdated
| use std::thread; | ||
| use std::time::SystemTime; | ||
|
|
||
| use crate::settings::global_user::get_wrangler_home_dir; |
There was a problem hiding this comment.
nit: this probably does not belong to global_user, but idk where to put it just now.
ashleymichal
approved these changes
May 27, 2020
EverlastingBugstopper
force-pushed
the
avery/check-for-updates
branch
2 times, most recently
from
ee9d346 to
2ecbd8c
Compare
This was referenced May 28, 2020
EverlastingBugstopper
force-pushed
the
avery/check-for-updates
branch
from
2ecbd8c to
1f4cc71
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397
every 24 hours, wrangler will ping crates.io and ask for the latest version. if latest version is greater than currently installed version, a message will be printed stating that the version needs updating. it saves the result from crates.io at
$WRANGLER_HOME/version.tomlwhich includes the latest version and the time it was last checked.