Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Revert default installer location change and release 1.14.1 #1798

Merged
merged 1 commit into from
Mar 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
# Changelog

## 1.14.1

- ### Fixes

- **revert default install location change - [xortive], [pull/1798]**

In 1.14.0, we changed the default install location from `~/.wrangler` to `node_modules`,
to allow `npx wrangler` to use the pinned version in a project's dependencies. It seems that
this is causing issues, so we're rolling it back in favor of having folks who want this behavior,
to specify a the install location in the `config` section of package.json. We'll document this soon.

[xortive]: https://github.com/xortive
[pull/1798]: https://github.com/cloudflare/wrangler/pull/1798

## 1.14.0

- ### Features
Expand Down
10 changes: 5 additions & 5 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "wrangler"
version = "1.14.0"
version = "1.14.1"
authors = ["The Wrangler Team <wrangler@cloudflare.com>", "Avery Harnish <averyharnish@gmail.com>", "Ashley Lewis <ashleymichal@gmail.com>", "Ashley Williams <ashley666ashley@gmail.com>", "Nat Davidson <davidson@cloudflare.com>", "Steve Manuel <nilslice@gmail.com>"]
edition = "2018"
license = "MIT/Apache-2.0"
Expand Down
14 changes: 8 additions & 6 deletions RELEASE_CHECKLIST.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,21 @@ Most of your comments will be about the changelog. Once the PR is finalized and

1. If you made changes, squash or fixup all changes into a single commit.
1. Run `git push` and wait for CI to pass.
## Merge

1. Hit the big green Merge button on the release PR.
1. `git checkout master` and `git pull --rebase origin master`

### Tag and build release

This part of the release process is handled by GitHub Actions, and our binaries are distributed as GitHub Releases. When you push a version tag, it kicks off an action that creates a new GitHub release for that tag, builds release binaries and attaches them to the release.

1. Once ready to merge, tag the commit by running either `git tag -a v#.#.# -m #.#.#` (release), or `git tag -a v#.#.#-rc.# -m #.#.#` (release candidate)
1. After pulling `master` in the step above, tag the commit by running either `git tag -a v#.#.# -m #.#.#` (release), or `git tag -a v#.#.#-rc.# -m #.#.#` (release candidate)
1. Run `git push --tags`.
1. Wait for CI to pass.
1. If CI fails, delete the tag locally and remotely
1. Fix whatever caused the CI failure
1. Re-tag the healthy commit, and wait for CI to pass again.

### Edit the release

Expand All @@ -74,11 +81,6 @@ After CI builds the release binaries and they appear on the [releases page](http

The new release candidate should then include updated testing instructions with a small changelog at the top to get folks who installed the old release candidate up to speed.

## Publish

1. Hit the big green Merge button on the release PR.
1. `git checkout master` and `git pull --rebase origin master`

### Publish to crates.io (full release only)

**IMPORTANT: This step is the hardest to fix if you mess it up. Do not run this step for Release Candidates**.
Expand Down
2 changes: 1 addition & 1 deletion npm/binary.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const getBinary = () => {
const customPath =
process.env.WRANGLER_INSTALL_PATH ||
process.env.npm_config_wrangler_install_path;
const installDirectory = join(customPath || __dirname, "wrangler");
const installDirectory = join(customPath || os.homedir(), ".wrangler");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return new Binary(url, { name: "wrangler", installDirectory });
};

Expand Down
4 changes: 2 additions & 2 deletions npm/npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion npm/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cloudflare/wrangler",
"version": "1.14.0",
"version": "1.14.1",
"description": "Command-line interface for all things Cloudflare Workers",
"main": "binary.js",
"scripts": {
Expand Down