This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Implement large bucket uploads split across multiple bulk KV API requests #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabbifish
added
status - needs review
regression
gabbifish
commented
Sep 17, 2019
gabbifish
changed the title
gabbifish
changed the title
gabbifish
changed the title
Merged
gabbifish
force-pushed
the
gabbi/add-multipart-bucket-upload
branch
from
c4bc47e to
8a5c24a
Compare
gabbifish
changed the title
gabbifish
force-pushed
the
gabbi/add-multipart-bucket-upload
branch
from
76d8341 to
6b53c98
Compare
ashleymichal
suggested changes
Sep 18, 2019
ashleymichal
approved these changes
Sep 18, 2019
delete-merged-branch
bot
deleted the
gabbi/add-multipart-bucket-upload
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #499.
It segments a large directory (bucket) upload to Workers KV into multiple KV calls if the payload (keys and values) provided is one of the below:
Otherwise, the logic simply uploads the key-value pairs without segmentation.
This logic has been tested with a directory of 50 2MB files, all uploaded to a Workers KV namespace.
Waiting on #613 to be merged into master before continuing this.