-
Notifications
You must be signed in to change notification settings - Fork 335
Add support for generating and initializing site projects #632
Conversation
note to self: I think it would be super important to highlight that folks bringing their own site generators should |
6d62dfd
to
7d4a673
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments attached! An overarching thing I'm a confused about is where the scaffolding is introduced--this PR makes it seem like it happens in init, but I guess I thought it was supposed to happen in generate?
@@ -182,6 +188,27 @@ fn setup_build(target: &Target) -> Result<(Command, PathBuf, Bundle), failure::E | |||
Ok((command, temp_file, bundle)) | |||
} | |||
|
|||
pub fn scaffold_site_worker(target: &Target) -> Result<(), failure::Error> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg this is still killing me. do we just go ahead with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving given the little time we have atm. we can do nitty cleanup later!
wrangler generate --site
wrangler init --site
inside an existing project, run