Mac and compatibility fixes #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkrasnov
reviewed
May 27, 2018
| @@ -50,6 +50,9 @@ | |||
| /* @(#) $Id$ */ | |||
|
|
|||
| #include "deflate.h" | |||
| #ifndef UINT32_MAX | |||
There was a problem hiding this comment.
Isn't the change for zconf.* sufficient?
| @@ -53,6 +55,17 @@ name: | |||
| #define ENDPROC(name) \ | |||
| .size name, .-name | |||
|
|
|||
| #else // __APPLE__ | |||
| GIT_BEGIN_DECL | ||
| # include "inttypes.h" | ||
| GIT_END_DECL | ||
| /** This check is needed for importing this file in an iOS/OS X framework throws an error in Xcode otherwise.*/ |
There was a problem hiding this comment.
Comment format (this and the rest) is /* text */ specifically space before and after, don't start with a capital
| /* ensure flags is 64 bit regardless whether uLong is 32 or 64 bit | ||
| */ | ||
| uint64_t flags64 = zlibCompileFlags(); | ||
| printf("zlib version %s = 0x%" PRIx64 ", compile flags = 0x%llx\n", |
There was a problem hiding this comment.
Inconsistent. Need yo replace all %ll with PRI. I also assumed that %04x was OK?
| ZLIB_VERSION, ZLIB_VERNUM, zlibCompileFlags()); | ||
| /* ensure flags is 64 bit regardless whether uLong is 32 or 64 bit | ||
| */ | ||
| uint64_t flags64 = zlibCompileFlags(); |
|
Not required with recent patches. |
fhanau
pushed a commit
to fhanau/zlib
that referenced
this pull request
Feb 27, 2023
Remove bad links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor modifications for #6