Add Signing Tool with Verified implementations for RSA as well as ECDSA with P-256 and P-384 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a signing tool to the kernel. Depending on the kernel configuration it uses verified implementations for SHA2. SHA3, RSA, ECDSA/P-256 and ECDSA/P-384.
A quick breakdown of the changes:
crypto/asymmetric_keys/: in the PKCS#8 parser, parse the algorithm parametercrypto/*-generated.c,crypto/*hacl*: Files that exclusively contain code generated/extracted from F*. Some code was removed (specifically the functions that don't do prehashed signing, but contain the hashing), and the#includeswere restructured.crypto/ecdsa.c: Based on the kernel configuration, either calls the unverified functions for signing, verifying and key generation or, if there is a verified implementation, uses the verified one.crypto/{Makefile,Kconfig}: add kernel build config and update the build system config to respect the settingsqzeta/signing_tool: The userland code calling the kernel syscalls. This consists of tests and benchmarks, as well as a cli for manually testing the syscalls.cc @franziskuskiefer @karthikbhargavan