-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a configurable way to manipulate the module version #76
Comments
Signed-off-by: Clemens Grabmann <clemens.grabmann@cloudflight.io>
Signed-off-by: Clemens Grabmann <clemens.grabmann@cloudflight.io>
Signed-off-by: Clemens Grabmann <clemens.grabmann@cloudflight.io>
…85) Signed-off-by: Clemens Grabmann <clemens.grabmann@cloudflight.io>
…85) Signed-off-by: Clemens Grabmann <clemens.grabmann@cloudflight.io> Signed-off-by: Philipp Hermüller <philipp.hermueller@cloudflight.io>
We should probably also consider https://blog.dipien.com/automatic-semantic-versioning-on-your-gradle-project-6343b626b27b |
I tried https://github.com/ajoberstar/reckon at https://github.com/cloudflightio/json-wrapper and looks really promising:
The workflow now is not to create a release any more via the Github pages and manually enter the release number, but instead you go to the actions, select the "Publish package to the Maven Central Repository" workflow and then you are prompted the following dialog: If we are currently running on 0.5.0-SNAPSHOT and the last release was 0.4.5, then depending on your selection of the scope, your new version will be:
No need to manually adjust any versions, just as mentioned in https://github.com/ajoberstar/reckon The tag is being created by the reckon plugin in this line. After that you can/should create the release-page under https://github.com/cloudflightio/json-wrapper/releases and the select the already created tag, and add the changelog there. |
Intersting is also the new ReckonSettingsPlugin which implements In case we would embed this plugin into ours we would most likely need to somehow reuse that concept, i.e. provide our own Settings plugin in addition to what we have already. |
…lugin for semantic versioning Signed-off-by: Klaus Lehner <172195+klu2@users.noreply.github.com>
…lugin for semantic versioning Signed-off-by: Klaus Lehner <172195+klu2@users.noreply.github.com>
…lugin for semantic versioning Signed-off-by: Klaus Lehner <172195+klu2@users.noreply.github.com>
…lugin for semantic versioning (#96) Signed-off-by: Klaus Lehner <172195+klu2@users.noreply.github.com>
We should - like in the old cloudflight-gradle-plugin - provide the possibility to manipulate the current version of a build.
In the old plugin, bound to TeamCity, we are using code like that:
The version number is therefore being adapted directly from the Gradle-Plugin, and is being enriched with data from the CI-Server
In contrary, in this repository here (autoconfigure-gradle-plugin) we are using a very simplified form:
The version for release builds is being injected by the CI-Server (Github Actions) in that case.
What we should do is to provide some kind of strategy interface to the autoconfigure-gradle-plugin which takes care about that, and which can also be configured/extended from outside. The default could be the version we are using here inside this plugin (just appending the
-SNAPSHOT
suffix for local builds)What we could do in any case is to propagate the build number of the root module to all other modules:
The text was updated successfully, but these errors were encountered: