Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Vagrantfile: do not use dns 8.8.8.8 if unreachable #345

Conversation

giner
Copy link

@giner giner commented Mar 4, 2016

Remove 8.8.8.8 from /etc/resolv.conf and /etc/resolvconf/resolv.conf.d/head if not reachable. External DNS is often blocked in private networks. In order avoid DNS timeouts we check if 8.8.8.8 is reachable when provisioning.

Remove 8.8.8.8 from /etc/resolv.conf and /etc/resolvconf/resolv.conf.d/head
if not reachable. External DNS is often blocked in private networks. In order
avoid DNS timeouts we check if 8.8.8.8 is reachable when provisioning.
@cfdreddbot
Copy link

Hey giner!

Thanks for submitting this pull request!

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

@cppforlife
Copy link
Contributor

@giner I think it's better to introduce a new env variable that allows to explicitly set DNS entries (or recomment people to use vagrant-dns). Also most vagrantfile changes should be done in the packaged vagrantfile instead of the example Vagrantfile: https://github.com/cloudfoundry/bosh-lite/blob/master/packer/templates/vagrant-local.tpl

@cppforlife
Copy link
Contributor

Closing as per comment above.

@cppforlife cppforlife closed this Mar 15, 2016
@giner
Copy link
Author

giner commented Mar 16, 2016

Normally DNS configuration is done by DHCP of your hypervisor and placing 8.8.8.8 as a primary DNS does not seem right. Therefore I would revert the following commit in this case d984f8c @cppforlife

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants