This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
remove flock in net.sh linux skeleton #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it is no longer needed since we have the '-w' flag for iptables - the extra locking with timeouts can cause containers to fail to start concurrently as they all contend for the same lock - this helps large numbers of containers to be created concurrently especially on 4.4 kernels
|
Hey zrob! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/133147561 The labels on this github issue will be updated when the story is started. |
cf-gitbot
added
unscheduled
scheduled
in progress
and removed
unscheduled
scheduled
labels
|
Looks good, going to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concurrently as they all contend for the same lock
especially on 4.4 kernels