Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to forward logs only from specific spaces #215

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Allow to forward logs only from specific spaces #215

wants to merge 2 commits into from

Conversation

Infra-Red
Copy link
Member

  1. Operator can specify multiple spaces by repeating --space flag.
  2. Run dep ensure to vendor missing dependencies.

/cc @pommi @diogomatsubara

@Infra-Red Infra-Red requested a review from shinji62 April 18, 2019 13:28
@pommi
Copy link

pommi commented Apr 21, 2019

Wow, 1236 files changed 🙀
Do you know why it drags in vendor/google.golang.org/genproto/googleapis/ads/googleads/*?

@Infra-Red
Copy link
Member Author

@pommi Missing dependencies were introduced in this PR.
Looks like vendor/google.golang.org/genproto/googleapis/ads/googleads/* is a dependency for the grpc and protobuf libraries, take a look at the dependency tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinji62 shinji62 Awaiting requested review from shinji62

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Infra-Red @pommi