Upgrade underscore version 1.9.x #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Painter <dpainte7@ford.com>
|
Sorry for the delay in responding, somehow this dropped off my radar. Did you ever find out why you were getting a 403 from the underscore tarball? I just tried here and it works fine. I can't imagine why getting the 1.8.x tarball would be blocked by your firewall, but a 1.9.x one wouldn't. I checked to see if there was a vulnerability against underscore from snyk.io - didn't see anything. Sometimes customers run software that blocks vulnerable versions from being downloaded. There's no real harm in upgrading either, so will merge shortly. |
|
I've merged this into master, and it's now available in cfenv 1.2.0 on npm. Thanks so much for your contribution, and again, sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into the following error when behind a corporate firewall and adding cfenv to a project from npm:
An unexpected error occurred: "http://registry.npmjs.org/underscore/-/underscore-1.8.3.tgz: Request failed \"403 Forbidden\"".We tested adding underscore 1.8.3 by itself to our project and got the same error as above. Adding underscore 1.9.x worked fine, so our assumption is that upgrading underscore to 1.9.x will resolve this problem for cfenv for users behind a corporate firewall.