Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework cf_app local download to use ioutil.Temp & clean up temp files #57

Closed
gberche-orange opened this issue Apr 3, 2018 · 1 comment
Closed

Rework cf_app local download to use ioutil.Temp & clean up temp files #57

gberche-orange opened this issue Apr 3, 2018 · 1 comment
Assignees
@ArthurHlt
Milestone
0.10.0

Comments

@gberche-orange
Copy link
Collaborator

This is a split of #38

It seems like the repo package is pulling a release locally, modifying it, and then it will be pushed up to Cloud Foundry as part of the resource_cf_app, is that understanding correct? You should switch to using the ioutil.Temp* methods instead of having the case where it uses the home directory. Also, please make sure to clean up any temp files or directories the provider creates during its execution.
@gberche-orange gberche-orange added this to the 1.0 milestone Apr 3, 2018
@gberche-orange gberche-orange mentioned this issue Apr 3, 2018
Closed
14 tasks
@ArthurHlt ArthurHlt self-assigned this Apr 3, 2018
ArthurHlt added a commit that referenced this issue Apr 4, 2018
@ArthurHlt
Rework cf_app local download to use ioutil.Temp & clean up temp files #…
dd4e731 
…57

@mevansam could you do code review please ?

I've removed inside `repo_manager.GetGitRepository` the ability to get back an already git cloned repository as temp directory can't be took again.
I think it's not that much useful as we run terraform on a pipeline so git cloned is anyway always performed. Also, issue #58 address this problem to not download for nothing.

About the cleaning, the way i fix it is definetely not the best way to do so but it seems that I will need to refactor `repo_manager`. Do you share this feeling @mevansam ?
@ArthurHlt
Copy link
Member

Close in favor of PR #70

janosbinder pushed a commit that referenced this issue Jul 17, 2018
@ArthurHlt @janosbinder
Rework cf_app local download to use ioutil.Temp & clean up temp files #…
8d6637e 
…57

@mevansam could you do code review please ?

I've removed inside `repo_manager.GetGitRepository` the ability to get back an already git cloned repository as temp directory can't be took again.
I think it's not that much useful as we run terraform on a pipeline so git cloned is anyway always performed. Also, issue #58 address this problem to not download for nothing.

About the cleaning, the way i fix it is definetely not the best way to do so but it seems that I will need to refactor `repo_manager`. Do you share this feeling @mevansam ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArthurHlt ArthurHlt

Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
2 participants
@gberche-orange @ArthurHlt