fix: move tcp-router healthcheck port to avoid clash #1526

andreas-kupries · 2020-10-28T19:39:33Z

The clash is in tcp-router and router both exporting port 80/http. Depending on racing in kubecf the wrong endpoint is exposed through the main service.

Description

Reconfigured the tcp_router job to not listen on 80/http for healthcheck requests any longer, and use custom port 88 instead.
Modified the health check probe to use port 88.
Modified ingress as well.

Motivation and Context

See #1199

How Has This Been Tested?

Minikube deployment, diego/SA. Roles are green, passed smoke and brain tests.
Use with ingress not tested.

This still needs testing on AWS, to be sure that the changed port is ok with AWS loadbalancers.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code has security implications.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.

[gh#kubecf-1199]

jandubois

Approving so that we get a build for SUSE QA to test on AWS because that was the only platform needing the healthcheck to enable the load balancer.

Please do not merge until tests have been successful.

prabalsharma · 2020-11-04T21:11:35Z

EKS testing:
Config: HA
Build: https://s3.eu-central-1.amazonaws.com/kubecf-ci/kubecf-bundle-0.0.0-20201103180702.1996.ge1e0408b-1604426855130.tgz

Smoke:

smoke/runtime/runtime.test
[1604513911] CF-Isolation-Segment-Smoke-Tests - 4 specs - 4 nodes SSSS SUCCESS! 11.517174058s 
[1604513911] CF-Logging-Smoke-Tests - 2 specs - 4 nodes S• SUCCESS! 43.296620476s 
[1604513911] CF-Runtime-Smoke-Tests - 2 specs - 4 nodes S• SUCCESS! 45.327257053s 

Ginkgo ran 3 suites in 1m40.182278299s
Test Suite Passed

Brians

Found 14 test files
Using seed: 1604514222289355414
Running test 001_pushapp_test.rb (1/14)
PASSED: 001_pushapp_test.rb

Running test 003_dockerapp_test.rb (2/14)
PASSED: 003_dockerapp_test.rb

Running test 018_autoscaler_test.rb (3/14)
SKIPPED: 018_autoscaler_test.rb

Running test 004_tcprouting_test.rb (4/14)
PASSED: 004_tcprouting_test.rb

Running test 006_ssh_test.rb (5/14)
PASSED: 006_ssh_test.rb

Running test 005_metron_test.rb (6/14)
PASSED: 005_metron_test.rb

Running test 010_insecure_registry_test.rb (7/14)
PASSED: 010_insecure_registry_test.rb

Running test 007_buildpacks_test.rb (8/14)
PASSED: 007_buildpacks_test.rb

Running test 002_securitygroups_test.rb (9/14)
PASSED: 002_securitygroups_test.rb

Running test 000_cflogin_test.rb (10/14)
PASSED: 000_cflogin_test.rb

Running test 009_backup_test.rb (11/14)
FAILED: 009_backup_test.rb

Test output:
+ cf api --skip-ssl-validation api.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website
Setting api endpoint to api.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website...
OK

api endpoint:   https://api.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website
api version:    2.153.0
API endpoint: https://api.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website
Authenticating...
OK
Use 'cf target' to view or set your target org and space.
+ cf create-org test-brain-org-66e3
Creating org test-brain-org-66e3 as admin...
OK

Assigning role OrgManager to user admin in org test-brain-org-66e3...
OK

TIP: Use 'cf target -o "test-brain-org-66e3"' to target new org
+ cf target -o test-brain-org-66e3
api endpoint:   https://api.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website
api version:    2.153.0
user:           admin
org:            test-brain-org-66e3
No space targeted, use 'cf target -s SPACE'
+ cf create-space test-space-org-c970
Creating space test-space-org-c970 in org test-brain-org-66e3 as admin...
OK
Assigning role SpaceManager to user admin in org test-brain-org-66e3 / space test-space-org-c970 as admin...
OK
Assigning role SpaceDeveloper to user admin in org test-brain-org-66e3 / space test-space-org-c970 as admin...
OK

TIP: Use 'cf target -o "test-brain-org-66e3" -s "test-space-org-c970"' to target new space
+ cf target -s test-space-org-c970
api endpoint:   https://api.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website
api version:    2.153.0
user:           admin
org:            test-brain-org-66e3
space:          test-space-org-c970
Set up users and org/space roles ...
+ cf create-user test-brain-org-66e3-OrgManager hunter2
Creating user test-brain-org-66e3-OrgManager...
OK

TIP: Assign roles with 'cf set-org-role' and 'cf set-space-role'.
+ cf set-org-role test-brain-org-66e3-OrgManager test-brain-org-66e3 OrgManager
Assigning role OrgManager to user test-brain-org-66e3-OrgManager in org test-brain-org-66e3 as admin...
OK
+ cf create-user test-brain-org-66e3-BillingManager hunter2
Creating user test-brain-org-66e3-BillingManager...
OK

TIP: Assign roles with 'cf set-org-role' and 'cf set-space-role'.
+ cf set-org-role test-brain-org-66e3-BillingManager test-brain-org-66e3 BillingManager
Assigning role BillingManager to user test-brain-org-66e3-BillingManager in org test-brain-org-66e3 as admin...
OK
+ cf create-user test-brain-org-66e3-OrgAuditor hunter2
Creating user test-brain-org-66e3-OrgAuditor...
OK

TIP: Assign roles with 'cf set-org-role' and 'cf set-space-role'.
+ cf set-org-role test-brain-org-66e3-OrgAuditor test-brain-org-66e3 OrgAuditor
Assigning role OrgAuditor to user test-brain-org-66e3-OrgAuditor in org test-brain-org-66e3 as admin...
OK
+ cf create-user test-space-org-c970-SpaceManager hunter2
Creating user test-space-org-c970-SpaceManager...
OK

TIP: Assign roles with 'cf set-org-role' and 'cf set-space-role'.
+ cf set-space-role test-space-org-c970-SpaceManager test-brain-org-66e3 test-space-org-c970 SpaceManager
Assigning role RoleSpaceManager to user test-space-org-c970-SpaceManager in org test-brain-org-66e3 / space test-space-org-c970 as admin...
OK
+ cf create-user test-space-org-c970-SpaceDeveloper hunter2
Creating user test-space-org-c970-SpaceDeveloper...
OK

TIP: Assign roles with 'cf set-org-role' and 'cf set-space-role'.
+ cf set-space-role test-space-org-c970-SpaceDeveloper test-brain-org-66e3 test-space-org-c970 SpaceDeveloper
Assigning role RoleSpaceDeveloper to user test-space-org-c970-SpaceDeveloper in org test-brain-org-66e3 / space test-space-org-c970 as admin...
OK
+ cf create-user test-space-org-c970-SpaceAuditor hunter2
Creating user test-space-org-c970-SpaceAuditor...
OK

TIP: Assign roles with 'cf set-org-role' and 'cf set-space-role'.
+ cf set-space-role test-space-org-c970-SpaceAuditor test-brain-org-66e3 test-space-org-c970 SpaceAuditor
Assigning role RoleSpaceAuditor to user test-space-org-c970-SpaceAuditor in org test-brain-org-66e3 / space test-space-org-c970 as admin...
OK
App to save ...
+ cf push node-env-3b28 -p /var/vcap/packages/acceptance-tests-brain/test-resources/node-env
Pushing app node-env-3b28 to org test-brain-org-66e3 / space test-space-org-c970 as admin...
Getting app info...
Creating app with these attributes...
+ name:       node-env-3b28
  path:       /var/vcap/packages/acceptance-tests-brain/test-resources/node-env
  routes:
+   node-env-3b28.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website

Creating app node-env-3b28...
Mapping routes...
Comparing local files to remote cache...
Packaging files to upload...
Uploading files...
 54.75 KiB / 54.75 KiB  100.00% 1s

Waiting for API to complete processing files...

Staging app and tracing logs...
   Downloading binary_buildpack...
   Downloading go_buildpack...
   Downloading python_buildpack...
   Downloading nginx_buildpack...
   Downloading php_buildpack...
   Downloaded binary_buildpack
   Downloaded python_buildpack
   Downloading staticfile_buildpack...
   Downloaded go_buildpack
   Downloading java_buildpack...
   Downloaded php_buildpack
   Downloading ruby_buildpack...
   Downloaded nginx_buildpack
   Downloading dotnet-core_buildpack...
   Downloading nodejs_buildpack...
   Downloaded java_buildpack
   Downloaded staticfile_buildpack
   Downloaded dotnet-core_buildpack
   Downloaded ruby_buildpack
   Downloaded nodejs_buildpack
   Cell diego-cell-1 creating container for instance ba2bde08-3307-4f14-88a9-1835ce1ea201
   Cell diego-cell-1 successfully created container for instance ba2bde08-3307-4f14-88a9-1835ce1ea201
   Downloading app package...
   Downloaded app package (202.5K)
   -----> Nodejs Buildpack version 1.7.33.1
   -----> Installing binaries
          engines.node (package.json): unspecified
          engines.npm (package.json): unspecified (use default)
          **WARNING** Node version not specified in package.json or .nvmrc. See: http://docs.cloudfoundry.org/buildpacks/node/node-tips.html
   -----> Installing node 10.22.1
          Download [https://cf-buildpacks.suse.com/dependencies/node/node-10.22.1-linux-x64-sle15-ab0bfcdd.tgz]
          Using default npm version: 6.14.6
   -----> Installing yarn 1.22.10
          Download [https://cf-buildpacks.suse.com/dependencies/yarn/yarn-1.22.10-62cab076.tar.gz]
          Installed yarn 1.22.10
   -----> Creating runtime environment
          PRO TIP: It is recommended to vendor the application's Node.js dependencies
          Visit http://docs.cloudfoundry.org/buildpacks/node/index.html#vendoring
          NODE_ENV=production
          NODE_HOME=/tmp/contents615773792/deps/0/node
          NODE_MODULES_CACHE=true
          NODE_VERBOSE=false
          NPM_CONFIG_LOGLEVEL=error
          NPM_CONFIG_PRODUCTION=true
   -----> Building dependencies
          Installing node modules (package.json)
   up to date in 0.261s
   found 0 vulnerabilities
          Contrast Security no credentials found. Will not write environment files.
   Exit status 0
   Uploading droplet, build artifacts cache...
   Uploading droplet...
   Uploading build artifacts cache...
   Uploaded build artifacts cache (22.4M)
   Uploaded droplet (22.8M)
   Uploading complete
   Cell diego-cell-1 stopping instance ba2bde08-3307-4f14-88a9-1835ce1ea201
   Cell diego-cell-1 destroying container for instance ba2bde08-3307-4f14-88a9-1835ce1ea201
   Cell diego-cell-1 successfully destroyed container for instance ba2bde08-3307-4f14-88a9-1835ce1ea201

Waiting for app to start...

name:              node-env-3b28
requested state:   started
routes:            node-env-3b28.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website
last uploaded:     Wed 04 Nov 18:30:50 UTC 2020
stack:             sle15
buildpacks:        nodejs

type:            web
instances:       1/1
memory usage:    1024M
start command:   node server.js
     state     since                  cpu    memory        disk        details
#0   running   2020-11-04T18:30:58Z   0.0%   20.6M of 1G   83M of 1G   

App active? ...
+ curl --head node-env-3b28.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
HTTP/1.1 200 OK
Date: Wed, 04 Nov 2020 18:31:01 GMT
X-Vcap-Request-Id: f7bf538e-73eb-4876-626e-4af49cfe26e9

+ curl --head node-env-3b28.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website | head -n1 | grep -w 200
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
HTTP/1.1 200 OK
Save everything ...
+ cf backup snapshot
2020/11/04 18:31:01 Retrieving resource /v2/quota_definitions
2020/11/04 18:31:01 org quota definitions done
2020/11/04 18:31:01 Retrieving resource /v2/space_quota_definitions
2020/11/04 18:31:01 space quota definitions done
2020/11/04 18:31:01 Retrieving resource /v2/organizations
2020/11/04 18:31:01 Retrieving resource /v2/organizations/9d1cdf73-e2bc-4081-ba08-de082161c4ef/auditors
2020/11/04 18:31:01 Retrieving resource /v2/organizations/9d1cdf73-e2bc-4081-ba08-de082161c4ef/managers
2020/11/04 18:31:01 Retrieving resource /v2/organizations/9d1cdf73-e2bc-4081-ba08-de082161c4ef/private_domains
2020/11/04 18:31:01 Retrieving resource /v2/quota_definitions/c0f1eb62-1294-4d2f-8e95-232f6bf90add
2020/11/04 18:31:01 Retrieving resource /v2/organizations/9d1cdf73-e2bc-4081-ba08-de082161c4ef/billing_managers
2020/11/04 18:31:01 Retrieving resource /v2/organizations/9d1cdf73-e2bc-4081-ba08-de082161c4ef/space_quota_definitions
2020/11/04 18:31:01 Retrieving resource /v2/organizations/9d1cdf73-e2bc-4081-ba08-de082161c4ef/spaces
2020/11/04 18:31:01 Retrieving resource /v2/organizations/9d1cdf73-e2bc-4081-ba08-de082161c4ef/domains
2020/11/04 18:31:02 Retrieving resource /v2/organizations/339b9b7e-5eeb-43f5-8104-97050b02d8d9/auditors
2020/11/04 18:31:02 Retrieving resource /v2/organizations/339b9b7e-5eeb-43f5-8104-97050b02d8d9/private_domains
2020/11/04 18:31:02 Retrieving resource /v2/organizations/339b9b7e-5eeb-43f5-8104-97050b02d8d9/billing_managers
2020/11/04 18:31:02 Retrieving resource /v2/organizations/339b9b7e-5eeb-43f5-8104-97050b02d8d9/spaces
2020/11/04 18:31:02 Retrieving resource /v2/organizations/339b9b7e-5eeb-43f5-8104-97050b02d8d9/domains
2020/11/04 18:31:02 Retrieving resource /v2/organizations/339b9b7e-5eeb-43f5-8104-97050b02d8d9/managers
2020/11/04 18:31:02 Retrieving resource /v2/organizations/339b9b7e-5eeb-43f5-8104-97050b02d8d9/space_quota_definitions
2020/11/04 18:31:02 Retrieving resource /v2/spaces/90ba63ae-3d7e-4d47-a3fa-581e1e7c81c7/apps
2020/11/04 18:31:02 Retrieving resource /v2/spaces/90ba63ae-3d7e-4d47-a3fa-581e1e7c81c7/managers
2020/11/04 18:31:03 Retrieving resource /v2/spaces/90ba63ae-3d7e-4d47-a3fa-581e1e7c81c7/routes
2020/11/04 18:31:03 Retrieving resource /v2/spaces/90ba63ae-3d7e-4d47-a3fa-581e1e7c81c7/domains
2020/11/04 18:31:03 Retrieving resource /v2/spaces/90ba63ae-3d7e-4d47-a3fa-581e1e7c81c7/auditors
2020/11/04 18:31:03 Retrieving resource /v2/spaces/90ba63ae-3d7e-4d47-a3fa-581e1e7c81c7/developers
2020/11/04 18:31:03 Retrieving resource /v2/users/d4eba4a9-7321-47d1-a613-1a123f715063/spaces
2020/11/04 18:31:03 Retrieving resource /v2/users/d4eba4a9-7321-47d1-a613-1a123f715063/organizations
2020/11/04 18:31:03 Retrieving resource /v2/users/314dcd9d-ad57-4652-b773-a36ba306cfbc/organizations
2020/11/04 18:31:03 Retrieving resource /v2/users/314dcd9d-ad57-4652-b773-a36ba306cfbc/spaces
2020/11/04 18:31:03 Retrieving resource /v2/spaces/7c03abe6-da03-4a11-ae12-fd8583adb803/routes
2020/11/04 18:31:03 Retrieving resource /v2/spaces/7c03abe6-da03-4a11-ae12-fd8583adb803/apps
2020/11/04 18:31:03 Retrieving resource /v2/spaces/7c03abe6-da03-4a11-ae12-fd8583adb803/developers
2020/11/04 18:31:04 Retrieving resource /v2/spaces/7c03abe6-da03-4a11-ae12-fd8583adb803/auditors
2020/11/04 18:31:04 Retrieving resource /v2/spaces/7c03abe6-da03-4a11-ae12-fd8583adb803/domains
2020/11/04 18:31:04 Retrieving resource /v2/spaces/7c03abe6-da03-4a11-ae12-fd8583adb803/managers
2020/11/04 18:31:04 Retrieving resource /v2/users/c36e912c-eace-46b1-9f24-56ebf214e022/organizations
2020/11/04 18:31:04 Retrieving resource /v2/users/c36e912c-eace-46b1-9f24-56ebf214e022/spaces
2020/11/04 18:31:04 Retrieving resource /v2/users/116bfaef-0ad9-4b95-8a45-4df1b458140e/organizations
2020/11/04 18:31:04 Retrieving resource /v2/users/116bfaef-0ad9-4b95-8a45-4df1b458140e/spaces
2020/11/04 18:31:04 Retrieving resource /v2/routes/b3802595-4941-45a0-b98f-840f75f615ac/route_mappings
2020/11/04 18:31:04 Retrieving resource /v2/routes/b3802595-4941-45a0-b98f-840f75f615ac/apps
2020/11/04 18:31:05 Retrieving resource /v2/apps/5708c048-b604-4b6c-98ec-2adf319f84e2/routes
2020/11/04 18:31:05 Retrieving resource /v2/apps/5708c048-b604-4b6c-98ec-2adf319f84e2/route_mappings
2020/11/04 18:31:05 Retrieving resource /v2/stacks/b12df25f-014a-4956-9ce9-66b2cd8d8ae6
2020/11/04 18:31:05 Retrieving resource /v2/users/5e156b01-9c25-4c9e-9e46-d2f2a108ea41/spaces
2020/11/04 18:31:05 Retrieving resource /v2/users/5e156b01-9c25-4c9e-9e46-d2f2a108ea41/organizations
2020/11/04 18:31:05 Retrieving resource /v2/users/4ef14511-94d5-4204-9813-bd39c1bd8530/spaces
2020/11/04 18:31:05 Retrieving resource /v2/users/4ef14511-94d5-4204-9813-bd39c1bd8530/organizations
2020/11/04 18:31:05 Retrieving resource /v2/users/beb5ad2c-f22c-46e2-b06d-b545dc1ce4cd/spaces
2020/11/04 18:31:05 Retrieving resource /v2/users/beb5ad2c-f22c-46e2-b06d-b545dc1ce4cd/organizations
2020/11/04 18:31:05 orgs done
2020/11/04 18:31:05 Retrieving resource /v2/shared_domains
2020/11/04 18:31:05 shared domains done
2020/11/04 18:31:05 Retrieving resource /v2/security_groups
2020/11/04 18:31:05 Retrieving resource /v2/security_groups/709077bc-dfff-46fe-9073-06363cf5ff5b/spaces
2020/11/04 18:31:05 Retrieving resource /v2/security_groups/dd9d884d-9a19-4d77-a546-3789a5d95015/spaces
2020/11/04 18:31:06 Retrieving resource /v2/security_groups/a90297dc-599a-4360-a8ec-80735aa23f70/spaces
2020/11/04 18:31:06 Retrieving resource /v2/security_groups/d650881c-c100-4ece-878a-250ac1092be5/spaces
2020/11/04 18:31:06 Retrieving resource /v2/security_groups/a75436e7-5365-4ee7-9d92-070657877d75/spaces
2020/11/04 18:31:06 Retrieving resource /v2/security_groups/be4f568f-dd4f-4edb-8eff-5ca8efc5b01b/spaces
2020/11/04 18:31:06 groups done
2020/11/04 18:31:06 Retrieving resource /v2/config/feature_flags
2020/11/04 18:31:06 feature flags done
2020/11/04 18:31:06 Saving bits for 1 apps
 1 / 1  100.00% 0s
App bits saved
Drop everything again ...
+ cf unset-org-role test-brain-org-66e3-OrgManager test-brain-org-66e3 OrgManager
Removing role OrgManager from user test-brain-org-66e3-OrgManager in org test-brain-org-66e3 as admin...
OK
+ cf unset-org-role test-brain-org-66e3-BillingManager test-brain-org-66e3 BillingManager
Removing role BillingManager from user test-brain-org-66e3-BillingManager in org test-brain-org-66e3 as admin...
OK
+ cf unset-org-role test-brain-org-66e3-OrgAuditor test-brain-org-66e3 OrgAuditor
Removing role OrgAuditor from user test-brain-org-66e3-OrgAuditor in org test-brain-org-66e3 as admin...
OK
+ cf unset-space-role test-space-org-c970-SpaceManager test-brain-org-66e3 test-space-org-c970 SpaceManager
Removing role SpaceManager from user test-space-org-c970-SpaceManager in org test-brain-org-66e3 / space test-space-org-c970 as admin...
OK
+ cf unset-space-role test-space-org-c970-SpaceDeveloper test-brain-org-66e3 test-space-org-c970 SpaceDeveloper
Removing role SpaceDeveloper from user test-space-org-c970-SpaceDeveloper in org test-brain-org-66e3 / space test-space-org-c970 as admin...
OK
+ cf unset-space-role test-space-org-c970-SpaceAuditor test-brain-org-66e3 test-space-org-c970 SpaceAuditor
Removing role SpaceAuditor from user test-space-org-c970-SpaceAuditor in org test-brain-org-66e3 / space test-space-org-c970 as admin...
OK
+ cf delete -f node-env-3b28
Deleting app node-env-3b28 in org test-brain-org-66e3 / space test-space-org-c970 as admin...
OK
+ cf delete-space -f test-space-org-c970
Deleting space test-space-org-c970 in org test-brain-org-66e3 as admin...
OK
TIP: No space targeted, use 'cf target -s' to target a space.
+ cf delete-org -f test-brain-org-66e3
Deleting org test-brain-org-66e3 as admin...
OK
Check everything that its gone ...
+ cf target -o test-brain-org-66e3
Organization 'test-brain-org-66e3' not found.
FAILED
Command exited with 1
Restore everything ...
+ cf backup restore
2020/11/04 18:31:15 Restoring shared domain: ci-eks-22e1f10e934dadae.qa.aws.howdoi.website
2020/11/04 18:31:15 WARNING: Error restoring shared domain ci-eks-22e1f10e934dadae.qa.aws.howdoi.website: Got CF-DomainNameTaken-The domain name is taken: ci-eks-22e1f10e934dadae.qa.aws.howdoi.website
2020/11/04 18:31:15 Restoring shared domain: apps.internal
2020/11/04 18:31:15 WARNING: Error restoring shared domain apps.internal: Got CF-DomainNameTaken-The domain name is taken: apps.internal
2020/11/04 18:31:15 Restoring Flag: user_org_creation
2020/11/04 18:31:15 Succesfully restored flag user_org_creation
2020/11/04 18:31:15 Restoring Flag: private_domain_creation
2020/11/04 18:31:15 Succesfully restored flag private_domain_creation
2020/11/04 18:31:15 Restoring Flag: app_bits_upload
2020/11/04 18:31:15 Succesfully restored flag app_bits_upload
2020/11/04 18:31:15 Restoring Flag: app_scaling
2020/11/04 18:31:15 Succesfully restored flag app_scaling
2020/11/04 18:31:15 Restoring Flag: route_creation
2020/11/04 18:31:16 Succesfully restored flag route_creation
2020/11/04 18:31:16 Restoring Flag: service_instance_creation
2020/11/04 18:31:16 Succesfully restored flag service_instance_creation
2020/11/04 18:31:16 Restoring Flag: diego_docker
2020/11/04 18:31:16 Succesfully restored flag diego_docker
2020/11/04 18:31:16 Restoring Flag: set_roles_by_username
2020/11/04 18:31:16 Succesfully restored flag set_roles_by_username
2020/11/04 18:31:16 Restoring Flag: unset_roles_by_username
2020/11/04 18:31:16 Succesfully restored flag unset_roles_by_username
2020/11/04 18:31:16 Restoring Flag: task_creation
2020/11/04 18:31:16 Succesfully restored flag task_creation
2020/11/04 18:31:16 Restoring Flag: env_var_visibility
2020/11/04 18:31:16 Succesfully restored flag env_var_visibility
2020/11/04 18:31:16 Restoring Flag: space_scoped_private_broker_creation
2020/11/04 18:31:16 Succesfully restored flag space_scoped_private_broker_creation
2020/11/04 18:31:16 Restoring Flag: space_developer_env_var_visibility
2020/11/04 18:31:16 Succesfully restored flag space_developer_env_var_visibility
2020/11/04 18:31:16 Restoring Flag: service_instance_sharing
2020/11/04 18:31:16 Succesfully restored flag service_instance_sharing
2020/11/04 18:31:16 Restoring Flag: hide_marketplace_from_unauthenticated_users
2020/11/04 18:31:16 Succesfully restored flag hide_marketplace_from_unauthenticated_users
2020/11/04 18:31:16 Restoring Flag: resource_matching
2020/11/04 18:31:16 Succesfully restored flag resource_matching
2020/11/04 18:31:16 Restoring organization: system
2020/11/04 18:31:16 WARNING: Error restoring organization system: Got CF-OrganizationNameTaken-The organization name is taken: system
2020/11/04 18:31:16 Restoring organization: test-brain-org-66e3
2020/11/04 18:31:16 Succesfully restored organization test-brain-org-66e3
2020/11/04 18:31:16 Restoring role for User: test-brain-org-66e3-OrgAuditor
2020/11/04 18:31:16 Retrieving resource /v2/users
2020/11/04 18:31:16 Succesfully restored user role organizations for user test-brain-org-66e3-OrgAuditor
2020/11/04 18:31:16 Restoring role for User: test-brain-org-66e3-OrgAuditor
2020/11/04 18:31:16 Retrieving resource /v2/users
2020/11/04 18:31:16 Succesfully restored user role audited_organizations for user test-brain-org-66e3-OrgAuditor
2020/11/04 18:31:16 Restoring role for User: test-brain-org-66e3-BillingManager
2020/11/04 18:31:16 Retrieving resource /v2/users
2020/11/04 18:31:17 Succesfully restored user role organizations for user test-brain-org-66e3-BillingManager
2020/11/04 18:31:17 Restoring role for User: test-brain-org-66e3-BillingManager
2020/11/04 18:31:17 Retrieving resource /v2/users
2020/11/04 18:31:17 Succesfully restored user role billing_managed_organizations for user test-brain-org-66e3-BillingManager
2020/11/04 18:31:17 Restoring role for User: admin
2020/11/04 18:31:17 Retrieving resource /v2/users
2020/11/04 18:31:17 Succesfully restored user role organizations for user admin
2020/11/04 18:31:17 Restoring role for User: admin
2020/11/04 18:31:17 Retrieving resource /v2/users
2020/11/04 18:31:17 Succesfully restored user role managed_organizations for user admin
2020/11/04 18:31:17 Restoring role for User: test-brain-org-66e3-OrgManager
2020/11/04 18:31:17 Retrieving resource /v2/users
2020/11/04 18:31:18 Succesfully restored user role organizations for user test-brain-org-66e3-OrgManager
2020/11/04 18:31:18 Restoring role for User: test-brain-org-66e3-OrgManager
2020/11/04 18:31:18 Retrieving resource /v2/users
2020/11/04 18:31:18 Succesfully restored user role managed_organizations for user test-brain-org-66e3-OrgManager
2020/11/04 18:31:18 Restoring space: test-space-org-c970
2020/11/04 18:31:18 Succesfully restored space test-space-org-c970
2020/11/04 18:31:18 Restoring role for User: test-space-org-c970-SpaceAuditor
2020/11/04 18:31:18 Retrieving resource /v2/users
2020/11/04 18:31:18 Succesfully restored user role audited_spaces for user test-space-org-c970-SpaceAuditor
2020/11/04 18:31:18 Restoring role for User: admin
2020/11/04 18:31:18 Retrieving resource /v2/users
2020/11/04 18:31:19 Succesfully restored user role spaces for user admin
2020/11/04 18:31:19 Restoring role for User: test-space-org-c970-SpaceDeveloper
2020/11/04 18:31:19 Retrieving resource /v2/users
2020/11/04 18:31:19 Succesfully restored user role spaces for user test-space-org-c970-SpaceDeveloper
2020/11/04 18:31:19 Restoring role for User: admin
2020/11/04 18:31:19 Retrieving resource /v2/users
2020/11/04 18:31:19 Succesfully restored user role managed_spaces for user admin
2020/11/04 18:31:19 Restoring role for User: test-space-org-c970-SpaceManager
2020/11/04 18:31:19 Retrieving resource /v2/users
2020/11/04 18:31:19 Succesfully restored user role managed_spaces for user test-space-org-c970-SpaceManager
2020/11/04 18:31:19 Retrieving resource /v2/stacks?q=name:sle15
2020/11/04 18:31:19 Restoring App node-env-3b28 for space test-space-org-c970 [1/1]
2020/11/04 18:31:19 Succesfully restored application node-env-3b28
2020/11/04 18:31:20 Updating app node-env-3b28
2020/11/04 18:31:20 Succesfully updated application node-env-3b28
2020/11/04 18:31:20 Retrieving resource /v2/shared_domains?q=name:ci-eks-22e1f10e934dadae.qa.aws.howdoi.website
2020/11/04 18:31:20 Creating route: node-env-3b28
2020/11/04 18:31:20 Succesfully created route node-env-3b28
2020/11/04 18:31:20 Binding route node-env-3b28.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website to app node-env-3b28
2020/11/04 18:31:20 Successfully bound route node-env-3b28.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website to app node-env-3b28
Check that everything is back ...
+ cf target -o test-brain-org-66e3 -s test-space-org-c970
api endpoint:   https://api.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website
api version:    2.153.0
user:           admin
org:            test-brain-org-66e3
space:          test-space-org-c970
+ cf org-users test-brain-org-66e3
Getting users in org test-brain-org-66e3 as admin...

ORG MANAGER
  admin
  test-brain-org-66e3-OrgManager

BILLING MANAGER
  test-brain-org-66e3-BillingManager

ORG AUDITOR
  test-brain-org-66e3-OrgAuditor
+ cf curl /v2/organizations/$(cf org test-brain-org-66e3 --guid)/managers?inline-relations-depth=1 > /tmp/009_backup_test-20201104-1538-bm2vva/users.json
+ cf curl /v2/organizations/$(cf org test-brain-org-66e3 --guid)/billing_managers?inline-relations-depth=1 > /tmp/009_backup_test-20201104-1538-bm2vva/users.json
+ cf curl /v2/organizations/$(cf org test-brain-org-66e3 --guid)/auditors?inline-relations-depth=1 > /tmp/009_backup_test-20201104-1538-bm2vva/users.json
+ cf curl /v2/spaces/$(cf space test-space-org-c970 --guid)/managers?inline-relations-depth=1 > /tmp/009_backup_test-20201104-1538-bm2vva/users.json
+ cf curl /v2/spaces/$(cf space test-space-org-c970 --guid)/developers?inline-relations-depth=1 > /tmp/009_backup_test-20201104-1538-bm2vva/users.json
+ cf curl /v2/spaces/$(cf space test-space-org-c970 --guid)/auditors?inline-relations-depth=1 > /tmp/009_backup_test-20201104-1538-bm2vva/users.json
Check app ...
+ cf apps | grep node-env-3b28
node-env-3b28   started           0/1         1G       1G     node-env-3b28.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website
App should be running / made to run ...
+ cf app node-env-3b28 | grep -E '^#.*running'
Command exited with 1
+ cf app node-env-3b28 | grep -E '^#.*running'
Command exited with 1
+ cf app node-env-3b28 | grep -E '^#.*running'
#0   running   2020-11-04T18:31:41Z   0.0%   20.5M of 1G   83M of 1G   
Check app routes ...
+ curl --head node-env-3b28.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
HTTP/1.1 200 OK
Date: Wed, 04 Nov 2020 18:31:45 GMT
X-Vcap-Request-Id: 8ea09fc7-e75e-4d92-4615-3a07062afe87

+ curl --head node-env-3b28.ci-eks-22e1f10e934dadae.qa.aws.howdoi.website | head -n1 | grep -w 200
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   111    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
Command exited with 1
+ cf delete -f node-env-3b28
Deleting app node-env-3b28 in org test-brain-org-66e3 / space test-space-org-c970 as admin...
OK
+ cf delete-user -f test-brain-org-66e3-OrgManager
Deleting user test-brain-org-66e3-OrgManager as admin...
OK
+ cf delete-user -f test-brain-org-66e3-BillingManager
Deleting user test-brain-org-66e3-BillingManager as admin...
OK
+ cf delete-user -f test-brain-org-66e3-OrgAuditor
Deleting user test-brain-org-66e3-OrgAuditor as admin...
OK
+ cf delete-user -f test-space-org-c970-SpaceManager
Deleting user test-space-org-c970-SpaceManager as admin...
OK
+ cf delete-user -f test-space-org-c970-SpaceDeveloper
Deleting user test-space-org-c970-SpaceDeveloper as admin...
OK
+ cf delete-user -f test-space-org-c970-SpaceAuditor
Deleting user test-space-org-c970-SpaceAuditor as admin...
OK
+ cf delete-space -f test-space-org-c970
Deleting space test-space-org-c970 in org test-brain-org-66e3 as admin...
OK
TIP: No space targeted, use 'cf target -s' to target a space.
+ cf delete-org -f test-brain-org-66e3
Deleting org test-brain-org-66e3 as admin...
OK
/var/vcap/packages/acceptance-tests-brain/test-scripts/testutils.rb:113:in `run': Command exited with 1 (RuntimeError)
	from /var/vcap/packages/acceptance-tests-brain/test-scripts/009_backup_test.rb:122:in `<main>'
Running test 011_nfspersi_test.rb (12/14)
SKIPPED: 011_nfspersi_test.rb

Running test 013_credhub_test.rb (13/14)
PASSED: 013_credhub_test.rb

Running test 017_syslog_forwarding_test.rb (14/14)
SKIPPED: 017_syslog_forwarding_test.rb

Tests complete: 10 Passed, 3 Skipped, 1 Failed

  Skipped tests:
    018_autoscaler_test.rb
    011_nfspersi_test.rb
    017_syslog_forwarding_test.rb

  Failed tests:
    009_backup_test.rb with exit code 1

andreas-kupries · 2020-11-05T00:36:16Z

The important part of the brains - The two tests using tcp-routing passed!

jandubois · 2020-11-05T16:07:04Z

The important part of the brains - The two tests using tcp-routing passed!

Does that mean we can press the big green "Merge pull request" button and be done with it?

andreas-kupries · 2020-11-05T16:11:21Z

IMHO yes. Let us wait until standup to check with @prabalsharma

prabalsharma · 2020-11-05T18:25:09Z

yes, I consider this as Passed

fix: move tcp-router healthcheck port to avoid clash

f3ae3b2

[gh#kubecf-1199]

andreas-kupries linked an issue Oct 28, 2020 that may be closed by this pull request

Sometimes port 80 goes to the tcp-router healthcheck #1199

Closed

Tweak chosen port, move out of system and into user range.

217cb62

jandubois approved these changes Nov 3, 2020

View reviewed changes

gaktive added the suse-cap label Nov 3, 2020

andreas-kupries merged commit 498b762 into master Nov 5, 2020

andreas-kupries deleted the ak-kubecf-1199-tcp-router-healthcheck-port-move branch November 5, 2020 18:25

gaktive added this to the 2.7.0 milestone Dec 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: move tcp-router healthcheck port to avoid clash #1526

fix: move tcp-router healthcheck port to avoid clash #1526

andreas-kupries commented Oct 28, 2020

jandubois left a comment

prabalsharma commented Nov 4, 2020

andreas-kupries commented Nov 5, 2020

jandubois commented Nov 5, 2020

andreas-kupries commented Nov 5, 2020

prabalsharma commented Nov 5, 2020

fix: move tcp-router healthcheck port to avoid clash #1526

fix: move tcp-router healthcheck port to avoid clash #1526

Conversation

andreas-kupries commented Oct 28, 2020

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

jandubois left a comment

Choose a reason for hiding this comment

prabalsharma commented Nov 4, 2020

andreas-kupries commented Nov 5, 2020

jandubois commented Nov 5, 2020

andreas-kupries commented Nov 5, 2020

prabalsharma commented Nov 5, 2020