This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Bump Eirini to v1 and fix eirini extensions #249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0rmiga
changed the title
Fix eirini extensions
Bump Eirini to v1 and fix eirini extensions
Dec 11, 2019
jimmykarily
commented
Dec 13, 2019
@@ -40,6 +40,11 @@ | |||
path: /instance_groups/name=api/jobs/name=file_server/properties/diego?/file_server/static_directory | |||
value: "/var/vcap/packages/" | |||
|
|||
# Enable volume services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a condition so we enable only when eirini is enabled?
aduffeck
reviewed
Dec 13, 2019
EOT | ||
) | ||
|
||
# Only patch once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to adapt this according to #261 in order to keep things consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed here: 22110fc
Signed-off-by: Dimitris Karakasilis <DKarakasilis@suse.com>
Signed-off-by: Dimitris Karakasilis <DKarakasilis@suse.com>
because we can't have a default since we don't know what storage class is available or the user wants to use.
also bump the acceptance test to a version that is built with the new stemcell
jimmykarily
force-pushed
the
fix_eirini_extensions
branch
from
December 13, 2019 09:37
f3d2576
to
22110fc
Compare
…bhooks Signed-off-by: Dimitris Karakasilis <DKarakasilis@suse.com>
aduffeck
approved these changes
Dec 13, 2019
bikramnehra
pushed a commit
that referenced
this pull request
Apr 21, 2020
Bump Eirini to v1 and fix eirini extensions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps Eirini and configures the ssh and persi extensions. ssh will not work until we use the sle15 eirinifs which starts sshd. To test one can simply start the sshd manually inside the app container.
Note: The configuration job which automatically sets up the Eirini persi broker is still missing
Motivation and Context
Bumps Eirini to v1 and fixes extensions. Fixes #151